Repository navigation
Conversation
|
@vonovak can we get this merged and released please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react/react-native@1449daa removed deprecated
Geometry.hheader, which is being used by this library, in favor of an umbrellaReact/Graphics.h. This PR updates the relevant code to use the new include when it's available instead.Test Plan
Build a React Native app with the library with the changes applied on RN 0.89 and <0.89.
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Before this PR, 0.89 build fails. After this PR it should succeed.
Compatibility
Android doesn't rely on checked-in Fabric descriptors, so it receives the correct include via codegen.
Checklist
README.mdexample/App.js)