Repository navigation
build: make lint install dependencies first like the other targets - #839
Conversation
CodeRabbit on #837: lint ran $(BIN)/eslint and $(BIN)/tsc with no $(BIN) prerequisite, so make lint on a fresh checkout failed, and under make -j a release target could start lint before the install finished. Swept the Makefile: lint was the only target using $(BIN) tools without the prerequisite. make -n with BIN on a missing path now runs yarn install first.
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Lint prerequisite Makefile |
The lint target now depends on $(BIN). |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Possibly related PRs
- react-grid-layout/react-draggable#837: Defines
$(BIN)as the dependency-install target that now runs before lint commands.
Merge Risk: 
85805
-
The change addresses lint setup ordering, with no actionable merge-blocking risk identified. Merge after normal checks pass.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: making the lint target install dependencies before running lint commands. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
make linton a fresh checkout fails: it runs$(BIN)/eslintand$(BIN)/tscwith no$(BIN)prerequisite, so nothing installsnode_modulesfirst, and undermake -jarelease-*target can start lint before the install finishes. Found by CodeRabbit on #837 (it predates that PR).lintwas the only target in the Makefile that used$(BIN)tools without the prerequisite.make -n BIN=<missing path> lintnow printsyarn installbefore eslint.Summary by CodeRabbit