[codex] expose scrollTop in extraRender info#357
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
Walkthrough本 PR 统一了多个文件对 ChangesVirtual List scrollTop 特性与导入统一
🎯 2 (Simple) | ⏱️ ~12 分钟Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/List.tsxOops! Something went wrong! :( ESLint: 8.57.1 Error: Cannot read config file: /.eslintrc.js
src/hooks/useFrameWheel.tsOops! Something went wrong! :( ESLint: 8.57.1 Error: Cannot read config file: /.eslintrc.js
src/hooks/useMobileTouchMove.tsOops! Something went wrong! :( ESLint: 8.57.1 Error: Cannot read config file: /.eslintrc.js
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #357 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 19 19
Lines 796 796
Branches 193 193
=======================================
Hits 776 776
Misses 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request introduces the scrollTop property to the ExtraRenderInfo interface and ensures it is correctly passed to the extraRender function within the RawList component. A new test case has been added to verify that the vertical scroll offset is accurately reported. I have no feedback to provide as there were no review comments.
e6819e7 to
eadf178
Compare
Summary
scrollToptoExtraRenderInfosoextraRenderconsumers can position overlay content against the current vertical scroll offset without reading DOM or stale refs.offsetTopasscrollTopwhen building theextraRenderinfo object.Validation
npm test -- scroll.test.js --runInBandnpm run lint(passes with existing warnings)Summary by CodeRabbit
发布说明
新功能
文档
测试