Repository navigation
fix: move pagination control semantics off list items #728
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| import React from 'react'; | ||
|
|
||
| interface PaginationItemProps extends React.LiHTMLAttributes<HTMLLIElement> { | ||
| disabled?: boolean; | ||
| } | ||
|
|
||
| /** Keep the list item structural when itemRender supplies a native control. */ | ||
| const PaginationItem: React.FC<PaginationItemProps> = ({ | ||
| children, | ||
| disabled, | ||
| onClick, | ||
| onKeyDown, | ||
| tabIndex, | ||
| 'aria-label': ariaLabel, | ||
| 'aria-current': ariaCurrent, | ||
| 'aria-disabled': ariaDisabled, | ||
| ...restProps | ||
| }) => { | ||
| const nativeControl = | ||
| React.isValidElement<React.HTMLProps<HTMLElement>>(children) && | ||
| (children.type === 'button' || children.type === 'a'); | ||
|
|
||
| if (!nativeControl) { | ||
| // Arbitrary components need not forward DOM props. Preserve their existing | ||
| // content and delegated interaction instead of wrapping interactive nodes. | ||
| return ( | ||
| <li | ||
|
There was a problem hiding this comment. React Doctor · Keyboard & screen reader users can't trigger this Fix → Put interactions on a button or link, or add an interactive role. |
||
| {...restProps} | ||
| onClick={onClick} | ||
| onKeyDown={onKeyDown} | ||
| tabIndex={tabIndex} | ||
| aria-label={ariaLabel} | ||
| aria-current={ariaCurrent} | ||
| aria-disabled={ariaDisabled} | ||
| > | ||
| {React.isValidElement(children) && | ||
| typeof children.type !== 'string' && | ||
| ariaDisabled !== undefined | ||
| ? React.cloneElement( | ||
| children as React.ReactElement<{ disabled?: boolean }>, | ||
| { disabled }, | ||
| ) | ||
| : children} | ||
| </li> | ||
| ); | ||
| } | ||
|
|
||
| const button = children.type === 'button'; | ||
| const link = !button && !!children.props.href; | ||
| const controlDisabled = disabled || (button && children.props.disabled); | ||
| const control = React.cloneElement(children, { | ||
| 'aria-hidden': undefined, | ||
| 'aria-label': children.props['aria-label'] ?? ariaLabel, | ||
| 'aria-current': ariaCurrent, | ||
| 'aria-disabled': controlDisabled || ariaDisabled, | ||
| tabIndex: controlDisabled ? -1 : 0, | ||
| ...(button ? { type: 'button', disabled: controlDisabled } : {}), | ||
| ...(!button && !link | ||
| ? { | ||
| role: 'button', | ||
| onKeyDown: (event: React.KeyboardEvent<HTMLElement>) => { | ||
| children.props.onKeyDown?.(event); | ||
| if (!event.defaultPrevented) { | ||
| onKeyDown?.(event as React.KeyboardEvent<HTMLLIElement>); | ||
| } | ||
| }, | ||
| } | ||
| : {}), | ||
| onClick: (event: React.MouseEvent<HTMLElement>) => { | ||
| if (controlDisabled) { | ||
| event.preventDefault(); | ||
| return; | ||
| } | ||
| children.props.onClick?.(event); | ||
| if (!event.isPropagationStopped()) { | ||
| onClick?.(event as React.MouseEvent<HTMLLIElement>); | ||
| } | ||
| }, | ||
| }); | ||
|
|
||
| // Native buttons synthesize clicks for Enter/Space; handling keydown on the | ||
| // parent as well would activate the same action twice. | ||
| return ( | ||
| <li {...restProps} aria-disabled={ariaDisabled}> | ||
| {control} | ||
| </li> | ||
| ); | ||
| }; | ||
|
|
||
| export default PaginationItem; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React Doctor ·
react-doctor/no-high-complexity-react-function(warning)PaginationItemhas cyclomatic complexity 16, cognitive complexity 15, and maximum nesting depth 2, so its React logic is hard to understand and change. Extract independent branches into components or hooks.Fix → Extract independent render branches and state logic into focused components or hooks until the control flow is easy to follow.
Docs