Repository navigation
fix(ci): upgrade Sass while avoiding 1.106 regression - #313
Merged
Merged
Conversation
Contributor
Playwright test resultsDetails
|
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report after GitHub Pages deployment completes: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-313/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
Contributor
npm beta publishedCI passed for the merge commit npm install @rdlabo/ionic-theme-ios27@2.0.0-beta.pr313.shae1c646a70d58 @rdlabo/capacitor-native-ui@2.0.0-beta.pr313.shae1c646a70d58 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ionic matrix installs use
--package-lock=false, which allowed Sass to advance to 1.106.0. That release crashes on valid empty attribute values, including the shared list selectors[helpertext='']and[errortext=''], breaking E2E and demo builds. The same minimal input fails in both expanded and compressed modes: upstream issue.Upgrade Sass from 1.97.3 to 1.105.2 and use
~1.105.2to allow patches on the working minor release while excluding 1.106.x until the upstream regression is fixed. Update its lockfile dependencies; no SCSS or workflow workaround is needed. Sass now requires Node 20.19+, which is satisfied by CI's Node 24.Validation:
hsla()/rgba()notation.npm run buildpassed with Ionic 9.npm run buildpassed.npm ci --no-audit --no-fundandgit diff --checkpassed.