Skip to content

fix(ci): upgrade Sass while avoiding 1.106 regression - #313

Merged
rdlabo merged 2 commits into
mainfrom
fix/ci-sass-version
Oct 21, 2026
Merged

rdlabo merged 2 commits into
mainfrom
fix/ci-sass-version

Conversation

@rdlabo

@rdlabo rdlabo commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Ionic matrix installs use --package-lock=false, which allowed Sass to advance to 1.106.0. That release crashes on valid empty attribute values, including the shared list selectors [helpertext=''] and [errortext=''], breaking E2E and demo builds. The same minimal input fails in both expanded and compressed modes: upstream issue.

Upgrade Sass from 1.97.3 to 1.105.2 and use ~1.105.2 to allow patches on the working minor release while excluding 1.106.x until the upstream regression is fixed. Update its lockfile dependencies; no SCSS or workflow workaround is needed. Sass now requires Node 20.19+, which is satisfied by CI's Node 24.

Validation:

  • Compiled all 41 SCSS files with 1.105.2 and compared them with 1.97.3: output is identical after normalizing equivalent white hsla() / rgba() notation.
  • npm run build passed with Ionic 9.
  • Ran the CI Ionic 8 install command, confirmed Sass remained at 1.105.2, and npm run build passed.
  • npm ci --no-audit --no-fund and git diff --check passed.

@rdlabo rdlabo changed the title fix(ci): pin Sass during Ionic matrix installs fix(ci): upgrade Sass while avoiding 1.106 regression Oct 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Playwright test results

passed  454 passed

Details

stats  454 tests across 24 suites
duration  3 minutes, 24 seconds
commit  569f9f3
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report after GitHub Pages deployment completes: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-313/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

@rdlabo
rdlabo merged commit e1c646a into main Oct 21, 2026
17 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

npm beta published

CI passed for the merge commit e1c646a70d58. Install the immutable version with:

npm install @rdlabo/ionic-theme-ios27@2.0.0-beta.pr313.shae1c646a70d58 @rdlabo/capacitor-native-ui@2.0.0-beta.pr313.shae1c646a70d58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant