Skip to content

fix: preserve Web rail order and relocate Ionic rail setup - #307

Merged
rdlabo merged 2 commits into
mainfrom
review/oss-repository
Oct 20, 2026
Merged

rdlabo merged 2 commits into
mainfrom
review/oss-repository

Conversation

@rdlabo

@rdlabo rdlabo commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

HTML Web rail proxies kept their original order after the source DOM was reordered, and newly prepended actions appeared at the end. Synchronize proxy order with the source while retaining button identity, click handlers, keyboard focus, and application-owned host content. Unchanged ordering does not move existing proxies.

Move the Ionic Vertical Bars setup guide from the theme package to capacitor-native-ui/docs/ionic-vertical-bars.md, where its runtime installation and lifecycle instructions belong. Update README, migration, documentation, and demo links, including relative paths within the moved guide.

Validation:

  • Workspace build passed.
  • All 161 unit tests passed, including a regression covering reorder, prepend, identity, click forwarding, focus, and host content.
  • Prettier and git diff --check passed.
  • Documentation links and heading anchors checked; old guide references removed.
  • Independent review approved after resolving the moved guide's ambiguous package reference.

The optional Ionic dependency footprint is deferred to #306 and is not changed here.

@rdlabo
rdlabo merged commit 9542c94 into main Oct 20, 2026
10 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Playwright test results

passed  454 passed

Details

stats  454 tests across 24 suites
duration  2 minutes, 58 seconds
commit  8eb1e39
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant