RDKB-66901 : Webui page with url "mac_ssid==" shows 500 Internal Error - #162
Closed
pavankumar464 wants to merge 3 commits into
Closed
pavankumar464 wants to merge 3 commits into
pavankumar464 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed validation change addresses the reported error without unresolved blocking issues.
Pull request overview
Fixes 500 errors caused by array-valued mac_ssid query parameters.
Changes:
- Safely validates
mac_ssidbefore regex processing. - Preserves numeric SSID range validation.
File summaries
| File | Description |
|---|---|
source/Styles/xb3/jst/includes/utility.jst |
Hardens mac_ssid query-parameter validation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Webui Wi-Fi page 500 Internal Error
Test Procedure: Test Webui Wi-Fi page MAC-filter
Risks: Low
Priority: P1