Cherrypick config api token auth - #345
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an opt-in API-token authentication toggle for the /config endpoint, allowing deployments to protect config retrieval without changing the default (legacy) unauthenticated behavior.
Changes:
- Introduces
webconfig.jwt.config_api_token_auth.enabled(defaultfalse) and wires it intoWebconfigServer. - Conditionally applies
ApiMiddlewareto/configrouting when enabled. - Suppresses “Request started/finished” info logs for
/configrequests and adds regression tests covering default auth behavior and log suppression.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
http/webconfig_server.go |
Adds config API token auth flag/state + suppresses request start/end info logs for /config. |
http/router.go |
Applies ApiMiddleware to /config only when the new flag is enabled. |
http/webconfig_server_test.go |
Adds tests for /config auth default/enablement and for log suppression behavior. |
config/sample_webconfig.conf |
Documents the new config_api_token_auth.enabled setting in the sample config. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.