Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed changes are consistent and no unresolved issues were identified.
Pull request overview
Adds a 3600-second PackageExpiryTime syscfg default for RDKDownloadManager across supported platforms.
Changes:
- Adds the default to XD4, BCI, and ARM system-default files.
- Ensures a consistent TTL on fresh devices.
File summaries
| File | Description |
|---|---|
source/scripts/init/defaults/system_defaults_xd4 |
Adds the 3600-second TTL default. |
source/scripts/init/defaults/system_defaults_bci |
Adds the 3600-second TTL default. |
source/scripts/init/defaults/system_defaults_arm |
Adds the 3600-second TTL default. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aryany310
changed the title
nhanasi
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKB-66953 : Migrate PackageExpiryTime to syscfg
Reason for change: Retain 3600 def value
Test Procedure: check package expiry param
Risks: Low
Priority: NA