RDKBDEV-3258: Fix syntax errro from RDKBDEV-3258 Remove UTOPIA mcast services (#80) - #416
Open
vlad-safonov wants to merge 1 commit into
Open
vlad-safonov wants to merge 1 commit into
vlad-safonov wants to merge 1 commit into
Conversation
vlad-safonov
force-pushed
the
RDKBDEV-3258-fix-syntax-error
branch
from
September 15, 2026 09:07
b54ddbc to
b1727de
Compare
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
Pull request overview
This PR fixes POSIX shell syntax in service_misc.sh for multicast service handling.
Changes:
- Replaces Bash
[[ ... ]]tests with POSIX-compatible[ ... ]. - Verifies multicast scripts are executable before invocation.
File summaries
| File | Summary |
|---|---|
source/scripts/init/service.d/service_misc.sh |
Corrects multicast service conditionals for /bin/sh compatibility. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vlad-safonov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: PR #80 introduced syntax error in script source/scripts/init/service.d/service_misc.sh
mixing bash and sh syntax with such output
this PR is fixing it
Test procedure: run service_misc.sh and ensure there are no errors
Risks: Low
Priority: P1