Add user and group options to DHCP server commands

[sherinjasper1506]

No description provided.

[github-actions]

📋 PR Format Reminder

• Title: Add user and group options to DHCP server commands — expected TICKET-123 : description
  (Multiple tickets OK: RDKCOM-5492 RDKBDEV-3336 : ... | Include US ticket + subtask for user-stories)
• Description missing:
  • Reason for change
  • Test Procedure
  • Risks (Low / Medium / High)
  • Priority (P0 / P1 / P2)

Expected:

TICKET-123 : brief description

Reason for change: why
Test Procedure: how to verify
Risks: Low / Medium / High
Priority: P0 / P1 / P2

[github-actions]

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

---

I have read the CLA Document and I hereby sign the CLA

---

_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}

[Copilot]

🟡 Changes recommended

It introduces an unconditional unlimited core-dump setting and applies the stated user/group change inconsistently across startup paths, which can cause operational risk and unclear behavior.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the DHCP server init script that launches dnsmasq, aiming to explicitly pass user/group settings when starting the service.

Changes:

• Adds --user=root --group=root to several dnsmasq start commands in the XDNS-enabled path.
• Enables unlimited core dumps via ulimit -c unlimited in the service script.

File summaries

File	Description
source/scripts/init/service.d/service_dhcp_server.sh	Adjusts dnsmasq startup arguments (user/group) and modifies process core-dump limits.

Review details

Suppressed comments (1)

source/scripts/init/service.d/service_dhcp_server.sh:143

• The PR title suggests adding --user/--group to the DHCP server commands, but the non-XDNS path (XDNS_ENABLE != true) still starts dnsmasq without these options. This makes behavior inconsistent depending on XDNS and may not satisfy the stated change.

                                $SERVER -q --user=root --group=root --clear-on-reload --bind-dynamic --add-mac --add-cpe-id=abcdefgh -P 4096 -C $DHCP_CONF $DNS_ADDITIONAL_OPTION --stop-dns-rebind --log-facility=/rdklogs/logs/dnsmasq.log #--enable-dbus
                        fi
                fi
         else
                $SERVER -P 4096 -C $DHCP_CONF $DNS_ADDITIONAL_OPTION  #--enable-dbus

• Files reviewed: 1/1 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.