RDKB-66054: Debug Log addition for Multiple Process Instances - #408
nivetha1766 wants to merge 2 commits into
Conversation
Reason for change: Identify and trace multiple process scenarios. Add MultiProcessDetect default configurations. Test Procedure: Refer the ticket Risks: Low Signed-off-by: Nivetha J <Nivetha_JosephJohnBritto@comcast.com>
There was a problem hiding this comment.
Pull request overview
This PR adds default syscfg values intended to enable/configure “MultiProcessDetect” so multiple-process scenarios can be detected on a periodic interval (per the PR description), by introducing new defaults in the ARM platform defaults file.
Changes:
- Add syscfg defaults for
MultiProcDetectEnable,MultiProcDetectExcludeDefaultList, andMultiProcDetectIntervalinsystem_defaults_arm.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| #MultiProcessDetect default configuration | ||
| $MultiProcDetectEnable=true | ||
| $MultiProcDetectExcludeDefaultList=sleep,dropbear,sh,ash,ssh,stunnel | ||
| $MultiProcDetectInterval=15 |
| #MultiProcessDetect default configuration | ||
| $MultiProcDetectEnable=true | ||
| $MultiProcDetectExcludeDefaultList=sleep,dropbear,sh,ash,ssh,stunnel | ||
| $MultiProcDetectInterval=15 |
Reason for change: Identify and trace multiple process scenarios. Test Procedure: Based on MultiProcessDetect RFCs, duplicate processes are detected and logged every specific interval. Risks: Low Priority: P1 Signed-off-by: Nivetha J <Nivetha_JosephJohnBritto@comcast.com>
There was a problem hiding this comment.
🟡 Changes recommended
The PR description/title claim debug log additions for multi-process detection, but the diff only adds default config values and contains no corresponding implementation/logging changes (or needs the PR metadata adjusted).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
| #MultiProcessDetect default configuration | ||
| $MultiProcDetectEnable=true | ||
| $MultiProcDetectExcludeDefaultList=sleep,dropbear,sh,ash,ssh,stunnel | ||
| $MultiProcDetectInterval=15 |
Reason for change: Identify and trace multiple process scenarios. Add MultiProcessDetect default configurations.
Test Procedure: Based on MultiProcessDetect RFCs, duplicate processes are detected and logged every specific interval.
Risks: Low
Priority: P1
Signed-off-by: Nivetha J Nivetha_JosephJohnBritto@comcast.com