rebase - #400
Merged
Merged
rebase#400
Conversation
Reason for change: Bind dropbear according to DeviceType RFC for prod images only Test Procedure: build and test ssh Risks: Low Priority: P1 Signed-off by : nareshkumar_m@comcast.com
… commercial (#399) Reason for change:Default params are missing XB-10 commercial Test Procedure: verify the logic and functionality Risks: High Priority: P1 --------- Co-authored-by: Shirish Shrivastava <163453477+sshriv323@users.noreply.github.com> Co-authored-by: Amaresh-Kotekal <Amaresh_Kotekal@comcast.com> Co-authored-by: Santosh Nayak <70348540+snayak002c@users.noreply.github.com>
|
📋 PR Format Reminder
Expected: |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates device configuration defaults and adjusts dropbear/sshd startup logic to choose between prod vs dev authorization keys based on build type and an RFC-provided device type.
Changes:
- Modify
service_sshd.shto select dev/prodauthorized_keysbased onBUILD_TYPEand RFCDeviceType. - Add GatewayManager factory default parameters to
system_defaults_bci.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
source/scripts/init/service.d/service_sshd.sh |
Changes the logic that determines whether dropbear uses dev vs prod authorized keys. |
source/scripts/init/defaults/system_defaults_bci |
Adds GatewayManager-related factory default values for the BCI profile. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+152
to
+157
| # Use prod keys only when both the build and deviceType RFC are prod; dev keys otherwise | ||
| USE_DEVKEYS="-f authorized_keys_dev" | ||
| DEVICETYPE=$(dmcli eRT getv Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Identity.DeviceType | grep value | cut -d ":" -f 3 | tr -d ' ' | tr -s ' ' | tr '[:lower:]' '[:upper:]') | ||
| if [ "$BUILD_TYPE" = "prod" -a "$DEVICETYPE" = "PROD" ]; then | ||
| USE_DEVKEYS="" | ||
| fi |
sindhu-krishnan
merged commit Aug 14, 2026
a69b4af
into
topic/chrony-nw-event
13 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.