RDKEMW-18410: Xconf thread should wait Indefinitely for the NTP indicator#372
Merged
Conversation
added 3 commits
May 19, 2026 14:34
…ator Signed-off-by: Yogeswaran K <yogeswaran_k@comcast.com>
…ator Signed-off-by: Yogeswaran K <yogeswaran_k@comcast.com>
…ator Signed-off-by: Yogeswaran K <yogeswaran_k@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the Xconf client's NTP sync wait behavior from a bounded 30-minute timeout to indefinite waiting once the NTP sync directory exists. The 30-minute timeout is now applied only to waiting for the NTP_SYNC_DIR to appear at startup (covering platforms where systimemgr may be absent). The previous pollForNTPSyncFallback function is repurposed/replaced by waitForNTPSyncDir, which only watches for the directory's appearance and then hands off to inotify for indefinite file-creation monitoring.
Changes:
- Replaced
NTP_SYNC_WAIT_TIMEOUT_SECwithNTP_SYNC_DIR_WAIT_TIMEOUT_SEC(scoped to directory appearance only). - Replaced
pollForNTPSyncFallbackwithwaitForNTPSyncDir; on success it retriesinotify_add_watchrather than polling for the file directly. - Removed the deadline check from the main
waitForNTPSyncinotify loop so it now waits indefinitely, exiting only on shutdown or indicator detection.
…ator Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
…ator Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
…ator Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
shibu-kv
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.