RDKEMW-25174 : Analytics events are not getting posted as expected wi… - #22
Open
gurpreet319 wants to merge 1 commit into
Open
gurpreet319 wants to merge 1 commit into
gurpreet319 wants to merge 1 commit into
Conversation
…th Nativescript wgt Reason for change: Handle libcurl upload retries by implementing CURLOPT_SEEKFUNCTION Test Procedure: build should be successful. Risks: low Priority: P2
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments remain.
Pull request overview
Adds libcurl seek support so in-memory request bodies can be rewound during upload retries.
Changes:
- Implements bounds-checked
SeekMemoryCallback. - Registers seek callbacks for network upload paths.
File summaries
| File | Description |
|---|---|
src/rtFileDownloader.cpp |
Adds in-memory upload seeking for libcurl retries. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…th Nativescript wgt
Reason for change: Handle libcurl upload retries by implementing CURLOPT_SEEKFUNCTION
Test Procedure: build should be successful.
Risks: low
Priority: P2