Nojira/fix cov build - #102
Open
brendanobra wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on making the coverage (Coverity) build more reliable by addressing dependency and toolchain mismatches (notably around GTest headers and transport bootstrapping), and by fixing missing standard library includes required by the SpeechSynthesis API.
Changes:
- Adds a CMake-time GTest header override mechanism to avoid header/version collisions during test builds.
- Fixes SpeechSynthesis compilation by including
<memory_resource>wherestd::pmr::vectoris part of the public API surface. - Makes transport bootstrapping more robust by parsing the transport release archive top-level directory without a fragile pipeline, and bumps the pinned transport version.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
test/CMakeLists.txt |
Adds logic to detect/override conflicting GTest headers and applies it to unit/component test targets. |
src/speechsynthesis_impl.h |
Adds <memory_resource> include related to std::pmr::vector usage. |
src/json_types/speechsynthesis.h |
Adds <memory_resource> include related to std::pmr::vector usage in JSON adapters. |
include/firebolt/speechsynthesis.h |
Adds <memory_resource> to support std::pmr::vector in the public interface. |
cov_build.sh |
Changes transport archive root-dir detection to a safer approach. |
.transport.version |
Updates FireboltTransport version used by the coverage build bootstrap. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+66
to
+71
| file(STRINGS "/usr/local/include/gtest/internal/gtest-internal.h" FIREBOLT_GTEST_LOCAL_SIGNATURE | ||
| REGEX "std::string test_suite_name" LIMIT_COUNT 1) | ||
| file(STRINGS "${FIREBOLT_GTEST_HEADER_ROOT}/gtest/internal/gtest-internal.h" FIREBOLT_GTEST_SELECTED_SIGNATURE | ||
| REGEX "const char\\* test_suite_name" LIMIT_COUNT 1) | ||
|
|
||
| if(FIREBOLT_GTEST_LOCAL_SIGNATURE AND FIREBOLT_GTEST_SELECTED_SIGNATURE) |
Comment on lines
+75
to
+82
| execute_process(COMMAND ${CMAKE_COMMAND} -E create_symlink | ||
| "${FIREBOLT_GTEST_HEADER_ROOT}/gtest" | ||
| "${FIREBOLT_GTEST_OVERRIDE_DIR}/gtest") | ||
| if(EXISTS "${FIREBOLT_GTEST_HEADER_ROOT}/gmock") | ||
| execute_process(COMMAND ${CMAKE_COMMAND} -E create_symlink | ||
| "${FIREBOLT_GTEST_HEADER_ROOT}/gmock" | ||
| "${FIREBOLT_GTEST_OVERRIDE_DIR}/gmock") | ||
| endif() |
Comment on lines
18
to
25
|
|
||
| #pragma once | ||
|
|
||
| #include <memory_resource> | ||
|
|
||
| #include <firebolt/helpers.h> | ||
| #include <firebolt/speechsynthesis.h> | ||
|
|
Comment on lines
18
to
25
|
|
||
| #pragma once | ||
|
|
||
| #include <memory_resource> | ||
|
|
||
| #include "firebolt/speechsynthesis.h" | ||
| #include <firebolt/json_types.h> | ||
|
|
Comment on lines
+141
to
+146
| while IFS= read -r entry; do | ||
| entry="${entry#./}" | ||
| if [[ -z "${release_dir}" && -n "${entry}" ]]; then | ||
| release_dir="${entry%%/*}" | ||
| fi | ||
| done < <(tar -tzf "${release_archive}") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.