Skip to content

RDKEMW-19865: Merge Develop to Main - #466

Merged
B-Larsen merged 1 commit into
mainfrom
develop
Aug 17, 2026
Merged

B-Larsen merged 1 commit into
mainfrom
develop

Conversation

@B-Larsen

Copy link
Copy Markdown
Contributor
  • RDKEMW-21185: Add exitcode on container stopped event

  • RDKEMW-21185: Add exitcode on container stopped event

  • Adding tests for container stopped events

  • Adding tests for container stopped events

Description

What does this PR change/fix and why?

If there is a corresponding JIRA ticket, please ensure it is in the title of the PR.

Test Procedure

How to test this PR (if applicable)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (doesn't fit into the above categories - e.g. documentation updates)

Requires Bitbake Recipe changes?

  • The base Bitbake recipe (meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updating SRC_REV)

* RDKEMW-21185: Add exitcode on container stopped event

* RDKEMW-21185: Add exitcode on container stopped event

* Adding tests for container stopped events

* Adding tests for container stopped events
Copilot AI lite review requested due to automatic review settings August 17, 2026 20:34
Comment thread client/lib/source/DobbyProxy.cpp Dismissed
Comment thread tests/L2_testing/test_runner/exit_code_tests.py Dismissed
Comment thread tests/L2_testing/test_runner/exit_code_tests.py Dismissed
Comment thread tests/L2_testing/test_runner/exit_code_tests.py Dismissed
Comment thread tests/L2_testing/test_runner/exit_code_tests.py Dismissed
Comment thread tests/L2_testing/test_runner/exit_code_tests.py Dismissed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR merges Develop into Main and introduces exit-code propagation for container stopped events by adding a new StoppedWithStatus signal pathway in DobbyProxy, plus accompanying L1 unit tests and L2 integration tests.

Changes:

  • Add a new status-aware listener API (registerListenerWithStatus) to receive container stop events with an exit code.
  • Subscribe to and dispatch a new StoppedWithStatus signal, extracting exit code from raw waitpid status.
  • Add L1 (GTest) and L2 (dbus-monitor-based) tests plus a new container spec used to force an exit code.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/L2_testing/test_runner/runner.py Registers the new L2 exit-code test module in the test runner.
tests/L2_testing/test_runner/exit_code_tests.py Adds L2 integration tests validating StoppedWithStatus emission and exit-code encoding.
tests/L2_testing/dobby_specs/exit_with_code.json Adds a container spec that exits with a known code (42) for L2 validation.
tests/L1_testing/tests/DobbyProxyTest/DobbyProxyTests.cpp Adds L1 unit tests for the new status-listener API and event parsing/dispatch behavior.
tests/L1_testing/tests/DobbyProxyTest/CMakeLists.txt Adds build rules for the new DobbyProxy L1 test executable.
tests/L1_testing/tests/CMakeLists.txt Includes the new DobbyProxyTest subdirectory in the L1 test build.
tests/L1_testing/mocks/IIpcServiceMock.h Extends the IPC service mock with isServiceAvailable used by DobbyProxy.
tests/L1_testing/mocks/IIpcServiceMock.cpp Implements the new IIpcService::isServiceAvailable mock shim method.
tests/L1_testing/mocks/IIpcService.h Extends the IPC service interface with isServiceAvailable.
client/lib/source/DobbyProxy.cpp Subscribes to StoppedWithStatus, parses raw status, and dispatches to status listeners with exit code.
client/lib/include/DobbyProxy.h Adds status listener API and extends internal event representation to carry exitCode.
AppInfrastructure/Public/Dobby/IDobbyProxy.h Extends the public proxy interface with a status-listener type and registration methods.
Suppressed comments (1)

tests/L2_testing/test_runner/exit_code_tests.py:159

  • The extract_int32_args() docstring says it returns tuples, but the function actually returns a list of dicts (with keys descriptor/name/raw_status). Update the docstring to match the real return type to avoid confusion.
    Returns a list of (descriptor, name, raw_status) tuples for each match.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread client/lib/source/DobbyProxy.cpp
Comment thread client/lib/include/DobbyProxy.h
Comment thread tests/L1_testing/tests/DobbyProxyTest/CMakeLists.txt
Comment thread tests/L2_testing/test_runner/exit_code_tests.py
@B-Larsen
B-Larsen merged commit 2b8d719 into main Aug 17, 2026
47 of 48 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants