This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Tear down workers after a trial is terminated by a scheduler - #254
Open
dcfidalgo wants to merge 1 commit into
Open
Tear down workers after a trial is terminated by a scheduler#254dcfidalgo wants to merge 1 commit into
dcfidalgo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #253
In the end, I figured out, that when a scheduler terminates a trial, we do not tear down the corresponding workers, and the necessary resources are not available for the subsequent trials.
The proposed solution works for my use case but feels very hacky. Maybe someone with a deeper knowledge about the inner workings of ray tune can come up with a more elegant solution.
Let me know what you think!