[sai-miduthuri]

Cherry-pick of #66477 (master commit f733abf) onto releases/2.60.0.

Bottom of a two-PR stack: #66860 (the pick of #66557) sits on top of this one and depends on it. #66557 isn't retroactive: a release-branch build runs that branch's own copy of the init script and reporter, and releases/2.60.0 was cut before either PR merged. Both picks are needed to run the observability agent on 2.60.0 release tests.

On its own this pick changes no behavior on the branch, since the agent stays master-only until #66860. It adds the GitHub issue comment path that #66557 builds on (and keeps master-only). Its prerequisites #65906, #65910 and #66006 are already on the branch.

Applied cleanly with git cherry-pick -x; the diff is identical to the master commit.

Not a duplicate: no existing PR against a release branch references #66477.

Testing, from the repo root of this branch with the repo venv (responses added to PYTHONPATH for test_test.py):

python -m pytest release/ray_release/tests/test_observability_agent_reporter.py release/ray_release/tests/test_test.py
107 passed

AI assistance was used to prepare this cherry-pick.

🤖 Generated with Claude Code

[gemini-code-assist]

Code Review

This pull request introduces a feature to comment the observability agent's Root Cause Analysis (RCA) directly on a test's open GitHub issue. It implements a deduplication mechanism using Buildkite meta-data to ensure only one job per build posts a comment, adds sanitization to prevent accidental GitHub mentions or issue linking, and handles truncation to fit within GitHub's comment size limits. Additionally, timeouts are added to GitHub client requests and Buildkite agent subprocess calls. The review feedback correctly identifies a critical issue where Buildkite meta-data keys will fail validation due to slashes in test names, and provides suggestions to sanitize the test names by replacing slashes with underscores.

[gemini-code-assist]

Buildkite meta-data keys are strictly validated and only allow alphanumeric characters, colons, dashes, and underscores ([a-zA-Z0-9_\-:]). Since release test names typically contain slashes (e.g., linux://...), using test.get_name() directly will cause the buildkite-agent meta-data commands to fail. This breaks the deduplication/claim mechanism entirely, causing duplicate comments on GitHub issues. We should sanitize the test name by replacing slashes with underscores.

Suggested change

	key = f"{COMMENT_CLAIM_PREFIX}{test.get_name()}"
	key = f"{COMMENT_CLAIM_PREFIX}{test.get_name().replace('/', '_')}"

[gemini-code-assist]

Sanitize the test name here as well to match the key format used when claiming the comment.

Suggested change

	self._meta_data("set", f"{COMMENT_CLAIM_PREFIX}{test.get_name()}", "")
	self._meta_data("set", f"{COMMENT_CLAIM_PREFIX}{test.get_name().replace('/', '_')}", "")

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 133f5ec. Configure here.}

[cursor]

Unclosed fences hide the slack link

Medium Severity

An unclosed fenced code block in the agent summary extends through the rest of the GitHub comment, so the slack feedback link is rendered as code instead of a link. _fit_summary can also cut through a fence and leave one open. The comment still posts, but the full-report link is no longer clickable.

Additional Locations (1)

• release/ray_release/reporter/observability_agent.py#L506-L511

 

^{Reviewed by Cursor Bugbot for commit 133f5ec. Configure here.}