fix: close release review findings - #22
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Tab IDs are not propagated from tabProperties, and the required changeset is missing.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Fixes credential fallback handling and Google Docs comment-anchor resolution.
Changes:
- Detects dangling/inaccessible encrypted credential paths.
- Propagates enclosing tab IDs to comment ranges.
- Adds regression tests for both areas.
| File | Description |
|---|---|
auth.rs |
Hardens encrypted credential detection and adds a symlink test. |
read.rs |
Adds tab context during anchor collection. |
read_tests.rs |
Tests anchors lacking explicit tab IDs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Owner
Author
|
Addressed all three Copilot findings in commit
Validation: 95 library tests, 758 CLI tests, 22 integration tests, 4 file-root tests, rustfmt, workspace Clippy, and repository hooks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Verification
This PR addresses the latest review findings on release PR #20 and should merge into
developbefore the release is promoted tomain.