Skip to content

Fix remaining specification review findings - #38

Merged
rasuvaeff merged 1 commit into
masterfrom
fix-specification-review-2026-09-13
Sep 13, 2026
Merged

rasuvaeff merged 1 commit into
masterfrom
fix-specification-review-2026-09-13

Conversation

@rasuvaeff

Copy link
Copy Markdown
Owner

Summary

  • preserve ORDER BY/LIMIT/OFFSET when a direct NotSpecification wraps a query tree
  • reject non-string canonical LIKE patterns in OrConditionSpecification
  • track build/.gitkeep and document LimitSpecification/OrderBySpecification
  • release changelog entry is 1.3.3; review report remains local and is not part of this PR

Verification

  • composer build: 324 tests, 4173 assertions
  • composer release-check: passed, including BC check
  • composer bench: 326 tests, 4175 assertions, 2 benchmarks passed
  • composer cs / composer psalm: passed
  • bin/package-audit specification: 0 errors, 0 warnings
  • examples/builder.php and examples/or-not-raw.php: passed

No tag or release was created.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 30b95e4c-bfed-4c38-a4d4-a7f84c9f51b8


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rasuvaeff
rasuvaeff merged commit 68491f2 into master Sep 13, 2026
10 checks passed
@rasuvaeff
rasuvaeff deleted the fix-specification-review-2026-09-13 branch September 19, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant