Render is / is not inside an OR condition as = / != like the comparison path

[rasuvaeff]

Fixes #34

Problem

withOrCondition(['status' => ['is', 'pending']]) — or an OrConditionSpecification built directly with ['is', 'status', 'pending'] — reached yiisoft/db verbatim and rendered "status" IS 'pending'. IS accepts only NULL / TRUE / FALSE / UNKNOWN on MySQL, MariaDB and PostgreSQL (ERROR 1064 / syntax error at or near "'pending'"). SQLite treats IS as null-safe equality and accepts it, which is why the integration suite stayed green.

The comparison path was already fine: visitComparison() maps is → = and is not → != and lets yiisoft/db render IS NULL for a null operand. Only the OR path skipped that mapping.

Fix

normalizeOrCondition() applies the same mapping to every three-element [is|is not, column, value] form, whatever the operand. A null operand still renders IS NULL / IS NOT NULL; anything else a plain equality — what new ComparisonSpecification('status', 'pending', 'is') already produced.

Narrowing the fromArray() shorthand instead was considered and rejected (see the issue): it leaves the direct constructor broken and turns the input into IN ('is', 'pending').

Tests

• QueryBuildingVisitorTest: provider with null / string / bool operands, upper-case IS, and the untouched forms (non-string column, two operands).
• SqliteIntegrationTest::orConditionIsRendersAsEquality asserts the SQL (= 'pending', IS NOT NULL, no IS '), not only the rows — the rows are identical on SQLite either way.

composer build — 309 tests, 2934 assertions, green. composer rector — green.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 5292546f-6e8c-4e13-9d03-2c5536fd5c05

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}