Skip to content

vcgencmd: Fix gencmd buffer length and result copy #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelwell merged 2 commits into from
Nov 11, 2026
+2 −2
Merged

vcgencmd: Fix gencmd buffer length and result copy #229

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64a389a
vcgencmd: Include the response word in the gencmd buffer length
popcornmix Nov 10, 2026
724b5a8
vcgencmd: Leave room for the terminator when copying the result
popcornmix Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vcgencmd/vcgencmd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ static unsigned gencmd(int file_desc, const char *command, char *result, int res
p[i++] = 0x00000000; // process request

p[i++] = GET_GENCMD_RESULT; // (the tag id)
p[i++] = MAX_STRING;// buffer_len
p[i++] = MAX_STRING + 4; // buffer_len: response word + command/result
p[i++] = 0; // request_len (set to response length)
p[i++] = 0; // error repsonse

Expand All @@ -110,7 +110,7 @@ static unsigned gencmd(int file_desc, const char *command, char *result, int res

mbox_property(file_desc, p);
result[0] = 0;
strncat(result, (const char *)(p+6), result_len);
strncat(result, (const char *)(p+6), result_len - 1);

return p[5];
}
Expand Down
Loading