Repository navigation
pieeprom-2026-10-22: 2711: Improve HTTP status handling (latest) - #907
Merged
Merged
Conversation
* Improve HTTP status handling The code currently only handles specific responses and doesn't treat an unexpected response as an error. An unexpected response will be treated as the file contents and fail the signature check. * Disable HTTP redirects For safety disable HTTP redirects. If you change HTTP_HOST you can re-enable redirects with HTTP_ALLOW_REDIRECTS=1 in the eeprom config. * sd_host: Fix the capacity calculation for pre-SDHC cards s->capacity was copied before the READ_BL_LEN adjustment. Only relevant for 1024, 2048 byte block cards. * sd_host: Fix potential infinite loop with CMD1 poll A card that keeps answering busy stalled boot indefinitely instead of failing over to the next boot mode. * Fix platform_error_msg timestamps platform_error_msg bypasses the usual logging infrastructure, and has its own copy of the old ms -> cs bug. Fix that bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code currently only handles specific responses and doesn't treat an unexpected response as an error. An unexpected response will be treated as the file contents and fail the signature check.
For safety disable HTTP redirects. If you change HTTP_HOST you can re-enable redirects with HTTP_ALLOW_REDIRECTS=1 in the eeprom config.
s->capacity was copied before the READ_BL_LEN adjustment. Only relevant for 1024, 2048 byte block cards.
poll A card that keeps answering busy stalled boot indefinitely instead of failing over to the next boot mode.
platform_error_msg bypasses the usual logging infrastructure, and has its own copy of the old ms -> cs bug. Fix that bug.