Skip to content

gst: Always set the smart resize and crop when configuring #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naushir merged 1 commit into from
Nov 4, 2026
Merged

gst: Always set the smart resize and crop when configuring #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions src/gst/gstpispconvert.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,21 +1027,16 @@ static gboolean gst_pisp_convert_configure(GstPispConvert *self)
GST_INFO_OBJECT(self, "Crop%u: offset=(%u,%u) size=%ux%u", i, crop.offset_x, crop.offset_y, crop.width,
crop.height);

/* Only call SetCrop if parameters changed */
if (memcmp(&crop, &self->priv->applied_crop[i], sizeof(crop)) != 0)
{
self->priv->backend->SetCrop(i, crop);
self->priv->applied_crop[i] = crop;
}
self->priv->backend->SetCrop(i, crop);

/* Only call SetSmartResize if parameters changed */
/* Always set the smart resize: the global config above resets rgb_enables to the
* input and outputs only, and libpisp re-enables the downscale/resample blocks only
* when the smart resize is dirty. Skipping it when the output size is unchanged left
* the resampler off after a reconfigure, so a new input format (or frame rate) at
* the same output size was shown unscaled, cropped and tiled wrongly. */
libpisp::BackEnd::SmartResize smart_resize = { (uint16_t)output_cfg[i].image.width,
(uint16_t)output_cfg[i].image.height };
if (memcmp(&smart_resize, &self->priv->applied_smart_resize[i], sizeof(smart_resize)) != 0)
{
self->priv->backend->SetSmartResize(i, smart_resize);
self->priv->applied_smart_resize[i] = smart_resize;
}
self->priv->backend->SetSmartResize(i, smart_resize);
}

/* Prepare the hardware configuration */
Expand Down
4 changes: 0 additions & 4 deletions src/gst/gstpispconvert.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,6 @@ struct _GstPispConvertPrivate
/* Crop settings per output */
pisp_be_crop_config crop[PISP_NUM_OUTPUTS];

/* Cached crop/resize settings (to avoid redundant API calls) */
pisp_be_crop_config applied_crop[PISP_NUM_OUTPUTS];
libpisp::BackEnd::SmartResize applied_smart_resize[PISP_NUM_OUTPUTS];

/* Input format info */
guint in_width;
guint in_height;
Expand Down
Loading