[main] enable auto-merge for highs/crits + add auto-approve renovate PR job - #624
Merged
thatmidwesterncoder merged 3 commits intoSep 21, 2026
Merged
Conversation
thatmidwesterncoder
requested review from
a team
and
a lite review from Copilot
September 17, 2026 16:47
There was a problem hiding this comment.
🟡 Changes recommended
Auto-merge and auto-approval scope must be narrowed to the intended security-only policy.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds Renovate security auto-merge configuration and a workflow for automatically approving eligible Renovate pull requests.
Changes:
- Adds scheduled/manual eligibility checks and GitHub App-based approvals.
- Configures security-focused Renovate auto-merge rules.
File summaries
| File | Summary | Findings |
|---|---|---|
.github/workflows/auto-approve-bot-prs.yml |
Validates and approves eligible Renovate PRs. | None noted. |
.github/renovate.json |
Defines Renovate auto-merge rules and branch presets. | Vulnerability matching is not limited to high/critical severity; release-branch presets can re-enable non-security auto-merge. |
Review details
Suppressed comments (1)
.github/renovate.json:39
- This branch-specific preset is expanded after the preceding local package rules, and the referenced release configuration extends
automerge.json, which enables automerge for non-security patch/minor updates. Consequently, release-branch Renovate PRs can still haveAutomerge: Enabledand this workflow will approve them, contrary to the stated security-only policy. Re-assert theautomerge: falsecatch-all after all branch-specificextendsentries, or remove the non-security automerge preset from these branches.
"extends": [
"github>rancher/renovate-config//rancher-main#main"
]
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
HarrisonWAffel
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
automerge snippet for renovate was yoinked from here: https://github.com/rancher/renovate-config/blob/main/automerge.json
essentially by importing that it would auto-approve everything - we are only doing auto-approve for security dependencies.
then just yoinked the auto-approve job from tim since it seemed pretty clean. we could always re-do this to be simpler and just auto-approve renovate bot PRs if automerge is enabled but this is battle tested over on fleet already.