Repository navigation
fix: call inline event handlers with the element as this - #137
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation correctly addresses the reported behavior and includes appropriate regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes inline event handlers so their this value matches native browser behavior.
Changes:
- Invokes preserved inline handlers with the originating element as
this. - Adds tests for handler context and event forwarding.
| File | Description |
|---|---|
src/events.js |
Corrects inline handler invocation context. |
tests/events.test.js |
Tests context binding and event delivery. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
markets
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136
Events.bind()now calls the original inline handler with the element asthis, the same as the browser does.on()is unchanged.Adds
tests/events.test.js, the first tests forEvents.