Repository navigation
Native animated welcome logo (Assemble, Shine, Glow pulse, Glitch, Embers) + modern-controls rule - #531
Draft
raiseCatError wants to merge 3 commits into
Conversation
…Shine, Glow pulse, Glitch, Embers)
… AGENTS rule and a guard test
renderValueControl('bool') drew a radio-style (*) toggle; it now uses checkMark like renderToggle. AGENTS.md names the
shared pickers, toggles and reviews to reuse, and tests/uiConsistency.test.ts fails on hand-drawn [x]/[ ] or (*)/( ) marks.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #530. NMSh's own welcome now animates a still logo image (PNG, JPEG or WebP, transparency kept). The frames are generated in memory from the still, with no GIF and no files, and are played through the same path animated GIF/APNG welcome images already use.
Also in this PR, following the maintainer's request for modern UI only:
renderValueControl('bool')now uses the shared checkmark (✔ / ·) instead of a radio-style(*).tests/uiConsistency.test.tsfails on hand-drawn[x]/[ ]or(*)/( )marks. A red check confirmed it catches the old toggle.Physical QA was done in a disposable Kitty 0.49.2 with forced Kitty graphics, using a generated test logo. Screenshots are in the evidence folder
welcome-anim/.Known gaps:
src/host/probe.ts).cancelMotion).Tests: 89 related focused tests pass, plus the new
welcomeLogoAnimationtests; tsc is clean.