Skip to content

Give Finder tool selections and Activity progress useful VoiceOver labels (#14) #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raiseCatError merged 3 commits into from
Oct 16, 2026
Merged

Give Finder tool selections and Activity progress useful VoiceOver labels (#14) #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08abf17
Label selection controls and job progress for VoiceOver
raiseCatError Oct 16, 2026
f57e067
Label selection controls and job progress for VoiceOver
raiseCatError Oct 16, 2026
e555d8c
Label selection controls and job progress for VoiceOver
raiseCatError Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/App/Duplicates/DuplicateScanner.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ private struct DuplicatesView: View {
else { selected.remove(proof.path) }
}
)).labelsHidden()
.accessibilityLabel("Select duplicate \(proof.path) for review")
Text(proof.path).font(.callout).lineLimit(2)
.textSelection(.enabled)
Spacer()
Expand Down
3 changes: 3 additions & 0 deletions Sources/App/SettingsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ struct SettingsView: View {
TuckPreferences.setEnabled(id, to: on)
}
)).labelsHidden()
.accessibilityLabel("Show \(action.title) in Finder")
Image(systemName: "line.3.horizontal").foregroundStyle(.tertiary)
}
}
Expand Down Expand Up @@ -288,6 +289,8 @@ struct SettingsView: View {
if job.status == .running {
ProgressView(value: job.progress)
.progressViewStyle(.linear)
.accessibilityLabel("\(job.title) progress")
.accessibilityValue("\(Int(job.progress * 100)) percent")
}
Text(job.progressDetail)
.font(.caption).foregroundStyle(.secondary)
Expand Down
1 change: 1 addition & 0 deletions Sources/App/ZIP/ZIPContentsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ private struct ZIPContentsView: View {
set: { on in if on { selected.insert(entry.name) }
else { selected.remove(entry.name) } }
)).labelsHidden()
.accessibilityLabel("Include \(entry.name) in extraction")
Image(systemName: entry.isDirectory ? "folder" : "doc")
Text(entry.name).textSelection(.enabled).lineLimit(2)
Spacer()
Expand Down
Loading