Skip to content

Bump rain-metadata 0.1.0 -> 0.1.7 and rain-lib-typecast 0.1.0 -> 0.1.4 - #581

Merged
thedavidmeister merged 2 commits into
mainfrom
2026-09-12-metadata-typecast-pins
Sep 12, 2026
Merged

thedavidmeister merged 2 commits into
mainfrom
2026-09-12-metadata-typecast-pins

Conversation

@thedavidmeister

@thedavidmeister thedavidmeister commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

This package spelled rain-metadata-0.1.0/ and rain-lib-typecast-0.1.0/ while its consumers install rain-metadata 0.1.7 (raindex, rain-metadata-deploy 0.1.1) and rainlang-interface 0.2.8 spells rain-lib-typecast 0.1.4. Soldeer installs one version per name, so raindex#2863 had to carry a cross-version alias remapping (rain-metadata-0.1.0/=dependencies/rain-metadata-0.1.7/) to compile this package's BaseRainlangSubParser. Aliases are not acceptable; the fix is here, upstream.

What changes

  • foundry.toml: rain-metadata 0.1.7, rain-lib-typecast 0.1.4. soldeer.lock and remappings.txt regenerated; the superseded 0.1.0 lines removed.
  • 18 import lines repointed (src/abstract/BaseRainlangSubParser.sol, BaseRainlangExpressionDeployer.sol, RainlangReferenceExtern.sol, LibAllStandardOps.sol, and test fixtures).

This package imports exactly one file from each: IDescribedByMetaV1.sol is byte-identical between 0.1.0 and 0.1.7; LibConvert.sol differs in NatSpec only. No bytecode moves.

Consumers pick this up at the next release; raindex then drops its alias.

QA

  • Discriminating tests: n/a, dependency pins and import prefixes only; the full suite (1552 tests, 225 suites) passes at the new pins.
  • Mutations applied: n/a, no logic change in this repo.
  • Oracle: diff of the installed 0.1.0 copies against the 0.1.7 / 0.1.4 tags of rain.metadata and rain.lib.typecast (identical / NatSpec-only); the Soldeer registry for the two versions.
  • Category check: remove the need for the downstream version alias by spelling the versions the tree already installs; covered. The wider rain-metadata bump to the current 0.1.43 is a separate campaign (rain-metadata-deploy pins 0.1.7 too).

🤖 Generated with Claude Code

https://claude.ai/code/session_01V8ViHcKLVk2YoS2joH4HdN

Summary by CodeRabbit

  • Chores
    • Updated the type-conversion library from version 0.1.0 to 0.1.4.
    • Updated the metadata library from version 0.1.0 to 0.1.7.
    • Updated related references across the project and test suite to use the newer versions.

baku-ccron and others added 2 commits September 12, 2026 11:31
Consumers install rain-metadata 0.1.7 (raindex, rain-metadata-deploy) and
rainlang-interface 0.2.8 spells rain-lib-typecast 0.1.4, so this package
spelling the 0.1.0 prefixes forced a cross-version alias remapping downstream.
Both files this repo imports are byte-identical at the new versions
(IDescribedByMetaV1) or NatSpec-only (LibConvert); no bytecode moves.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V8ViHcKLVk2YoS2joH4HdN
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 27a0b9ce-21f0-4c2d-93da-f53f9a75de2e

📥 Commits

Reviewing files that changed from the base of the PR and between 02c2527 and e7390df.

⛔ Files ignored due to path filters (1)
  • soldeer.lock is excluded by !**/*.lock
📒 Files selected for processing (19)
  • foundry.toml
  • remappings.txt
  • src/abstract/BaseRainlangExpressionDeployer.sol
  • src/abstract/BaseRainlangSubParser.sol
  • src/concrete/extern/RainlangReferenceExtern.sol
  • src/lib/op/LibAllStandardOps.sol
  • test/concrete/TestRainlangExpressionDeployer.sol
  • test/lib/integrity/LibIntegrityFnPointers.sol
  • test/lib/parse/LibMetaFixture.sol
  • test/src/abstract/BaseRainlangSubParser.ierc165.t.sol
  • test/src/abstract/EmptyWordParsersSubParser.sol
  • test/src/abstract/HappyPathLiteralSubParser.sol
  • test/src/abstract/MismatchedWordSubParser.sol
  • test/src/concrete/RainlangExpressionDeployer.ierc165.t.sol
  • test/src/concrete/RainlangReferenceExtern.ierc165.t.sol
  • test/src/lib/integrity/IntegrityHighwater.sol
  • test/src/lib/integrity/IntegritySingleOp.sol
  • test/src/lib/parse/LibParse.namedLHS.t.sol
  • test/src/lib/parse/LibParse.singleRHSNamed.gas.t.sol

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The project updates rain-lib-typecast to 0.1.4 and rain-metadata to 0.1.7. Configuration, remappings, production imports, and test imports now use these versions.

Changes

Dependency Version Updates

Layer / File(s) Summary
Update dependency pins and remappings
foundry.toml, remappings.txt
The configured dependency pins and remappings now reference rain-lib-typecast 0.1.4 and rain-metadata 0.1.7.
Update production imports
src/abstract/*, src/concrete/extern/RainlangReferenceExtern.sol, src/lib/op/LibAllStandardOps.sol
Production imports now reference the updated LibConvert and IDescribedByMetaV1 packages.
Update test imports
test/concrete/*, test/lib/*, test/src/*
Test imports now reference the updated dependency packages.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to e7390

This dependency-only update is ready to merge with no material current-head risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes both dependency version updates, which are the main changes in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-09-12-metadata-typecast-pins

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thedavidmeister
thedavidmeister merged commit 7e47331 into main Sep 12, 2026
5 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant