Repository navigation
ci: remove orphaned foundry.lock left over from soldeer migration - #2714
Conversation
Issue #2560 asked for a CI step that runs `forge update` on the four git submodules recorded in `foundry.lock` (lib/rain.deploy, lib/rain.interpreter, lib/rain.raindex.interface, lib/sushixswap-v2) and asserts no git diff, to keep `foundry.lock` revs consistent with the submodule pointers and reachable upstream. That was the right fix for the bug shipped at #2558 — a `foundry.lock` rev that did not exist upstream passed CI silently. Since then, #2586 ("migrate raindex to soldeer for dependency management", merged 2026-05-29) deleted all four git submodules and `.gitmodules`; every Solidity dependency is now Soldeer-managed via `soldeer.lock` + `[dependencies]` in `foundry.toml`. The submodules the proposed `forge update` check would iterate no longer exist, so the literal check is moot. `foundry.lock` itself was not removed by #2586 and is now a dead, unreferenced artifact pointing at submodules that are gone (sushixswap-v2 was dropped entirely; the other three became the soldeer deps rain-deploy / rain-interpreter-interface+rainlang / raindex-interface). The smallest correct fix that resolves the exact inconsistency the issue worries about — a dependency lockfile that disagrees with the tree and can silently pass CI — is to delete the orphaned lockfile. No CI job reads it: the cache key in rainix-sol-{test,static}.yaml hashes `soldeer.lock`, not `foundry.lock`, and deps come from `forge soldeer install`. Also drop the two now-dangling housekeeping references to the file: - REUSE.toml annotation entry (kept `reuse lint` happy for the file). - .soldeerignore exclude line (excluded it from the soldeer publish zip). Verification (nix develop github:rainlanguage/rainix#sol-shell): - `reuse lint` -> compliant, 1139/1139 files, 0 errors, 0 unused licenses. - `forge soldeer install` -> deps installed from soldeer.lock, foundry.lock not consulted. - `forge build` -> compiles clean (exit 0; only pre-existing unsafe-typecast lint warnings in test files, unrelated to this change). Fixes #2560 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 57 minutes and 4 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Reviewed ee63d46: Removes the orphaned foundry.lock left over from the submodule->soldeer migration (Solidity deps are pinned via foundry.toml [dependencies] + soldeer.lock now), and drops its stale REUSE.toml / .soldeerignore entries. CI/housekeeping only - no src, bytecode, or subgraph impact. All checks green. LGTM. |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
What
Removes the orphaned
foundry.lock(the old git-submodule dependency lockfile) and its two now-dangling housekeeping references inREUSE.tomland.soldeerignore.Why
Issue #2560 asked for a CI step that runs
forge updateon the four git submodules recorded infoundry.lock(lib/rain.deploy,lib/rain.interpreter,lib/rain.raindex.interface,lib/sushixswap-v2) and assertsgit diff --exit-code, to keep the lockfile revs consistent with the submodule pointers and reachable upstream. That was the correct fix for the bug shipped at #2558 — afoundry.lockrev that did not exist upstream passed CI silently and only broke when a downstreamforge updatehitfatal: unable to read tree.Since the issue was filed, #2586 ("migrate raindex to soldeer for dependency management", merged 2026-05-29) deleted all four git submodules and
.gitmodules. Every Solidity dependency is now Soldeer-managed viasoldeer.lock+[dependencies]infoundry.toml(foundry.tomleven states: "All Solidity dependencies are Soldeer-managed; no git submodules remain.").So the submodules the proposed
forge updatecheck would iterate no longer exist — the literal check is moot. Butfoundry.lockitself was not removed by #2586 and is now a dead, unreferenced artifact pointing at submodules that are gone (sushixswap-v2 was dropped entirely; the other three became the soldeer depsrain-deploy/rain-interpreter-interface+rainlang/raindex-interface).The smallest correct fix that resolves the exact inconsistency the issue worries about — a dependency lockfile that disagrees with the tree and can silently pass CI — is to delete the orphaned lockfile so there is no longer any such file to drift. No CI job reads it: the Foundry cache key in rainix's
rainix-sol-{test,static}.yamlhashessoldeer.lock(notfoundry.lock), and dependencies come fromforge soldeer install.Also drops the two now-dangling housekeeping references to the file:
REUSE.tomlannotation entry (it keptreuse linthappy for the file)..soldeerignoreexclude line (it excluded the file from the soldeer publish zip).Verification
Run in
nix develop github:rainlanguage/rainix#sol-shell:reuse lint→ compliant, 1139/1139 files, 0 errors, 0 unused licenses (confirms theREUSE.tomledit is clean).forge soldeer install→ dependencies installed fromsoldeer.lock;foundry.lockis not consulted.forge build→ compiles clean (exit 0; only pre-existingunsafe-typecastlint warnings in test files, unrelated to this change).Fixes #2560
🤖 Generated with Claude Code