Skip to content
This repository was archived by the owner on Aug 5, 2026. It is now read-only.
This repository was archived by the owner on Aug 5, 2026. It is now read-only.

i was asked to infinite approve quick on deposit #139

Open

Description

@thedavidmeister

don't infinite approve

Activity

  1. Siddharth2207 commented on Oct 15, 2024

    @Siddharth2207
    Contributor
    • I have the browser rabby wallet connected to the rainbow wallet on my phone.
    • The connect browser connected rabby wallet seems to have correct calldata :
      Image
    • But in the rainbow wallet on phone, notification seems to be for infinite approval.
      Image
  2. deleted a comment from on Oct 22, 2024
  3. thedavidmeister commented on Jul 29, 2026

    @thedavidmeister
    ContributorAuthor

    🤖 ai:producer
    Close-candidate: invalid: rain.webapp has never encoded an infinite approval, so there is nothing in this repo to fix. git log -S 'maxUint256' --all and git log -S 'MaxUint256' --all both return ZERO commits across every branch. All three approve call sites pass the exact parsed deposit amount: app/_components/SubmissionModal.tsx:198-203 args: [orderBookAddress, depositAmount] (byte-identical at c0be9ff, 2024-10-11, the day of the report), app/_components/DepositModal.tsx:159-165 args: [vault.orderbook.id, parsedAmount], and the Frames path app/_services/frameTransactions.ts:35-39 args: [orderBookAddress, depositAmount]. The reporter's own MEMBER follow-up on this issue confirms it: the actually-connected browser wallet (Rabby) showed correct calldata, and only the Rainbow MOBILE PUSH NOTIFICATION rendered it as 'infinite approval' — third-party wallet display, outside this codebase. Not a GUI claim against this repo's own render, so no screenshot applies.

  4. thedavidmeister commented on Jul 29, 2026

    @thedavidmeister
    ContributorAuthor

    🤖 ai:vetter
    Reviewed close-candidate @2026-07-29T13:19:24Z: uphold — Invalid-claim proven at the report-day commit (c0be9ff byte-identical): all three approve sites pass the exact parsed deposit amount, no max-uint spelling anywhere in history, and the reporter's own member follow-up attributes the "infinite approval" display to Rainbow's mobile push notification while the connected wallet showed correct calldata — third-party wallet rendering, not this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ai:close-candidateAI vetter: candidate to closebugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions