Skip to content

Pin rain-math-float 0.2.1 - #23

Merged
thedavidmeister merged 2 commits into
mainfrom
2026-09-08-rain-math-float-0.2.1
Sep 8, 2026
Merged

Pin rain-math-float 0.2.1#23
thedavidmeister merged 2 commits into
mainfrom
2026-09-08-rain-math-float-0.2.1

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

Pins rain-math-float 0.2.1 (rain.math.float#274: FLOAT_PI, and the library's own Rust tests) in place of 0.1.7, rewriting the versioned import prefixes. The other pins already matched what 0.2.1 imports (rain-solmem 0.1.28, rain-string 0.2.0, rain-datacontract 0.1.9).

DecimalFloat does not reference the new constant, so its bytecode, the Zoltu address and src/generated/candidate/ are unchanged: Build.sol regenerates to the committed record and CopyArtifacts to the committed ABIs. No deploy, no release cut.

This is also the first merge to main after the deploy key lands, so it retriggers Crate + npm Release, which has failed on the main ruleset since 2026-08-22.

QA

  • Discriminating tests: the concrete suites over the new pin, forge test 71 passed locally with the 6 fork tests skipped for lack of RPC env (they run in CI); cargo test --features test-harness 10 passed + 37 doctests, clippy clean; git-clean currency (candidate + ABIs) clean after regeneration.
  • Mutations applied: n/a, a pin bump with no logic change; the candidate record being byte-identical after Build.sol is the check that the bump changed nothing deployed.
  • Oracle: the committed src/generated/candidate/ and crates/float/abi/*.json, regenerated from the new dependency tree and diffed.
  • Category check: dependency bump only; the deploy pins, [external.package].version and the frozen snapshots are untouched.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QyCCzi9WZPhuXcU1hwr2bq

FLOAT_PI and the library's own Rust tests. DecimalFloat does not reference
the constant, so the candidate record and ABIs regenerate unchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QyCCzi9WZPhuXcU1hwr2bq
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 21beef8e-7989-4360-a13b-e61f7f1fcfb3

📥 Commits

Reviewing files that changed from the base of the PR and between f28c5ea and d406d6a.

⛔ Files ignored due to path filters (1)
  • soldeer.lock is excluded by !**/*.lock
📒 Files selected for processing (40)
  • foundry.toml
  • script/Build.sol
  • src/concrete/DecimalFloat.sol
  • src/lib/deploy/LibDecimalFloatDeploy.sol
  • test/concrete/DecimalFloat.packLossless.t.sol
  • test/concrete/TestDecimalFloat.sol
  • test/concrete/TestDecimalFloat.unpack.t.sol
  • test/src/concrete/DecimalFloat.abs.t.sol
  • test/src/concrete/DecimalFloat.add.t.sol
  • test/src/concrete/DecimalFloat.ceil.t.sol
  • test/src/concrete/DecimalFloat.constants.t.sol
  • test/src/concrete/DecimalFloat.constructor.t.sol
  • test/src/concrete/DecimalFloat.div.t.sol
  • test/src/concrete/DecimalFloat.eq.t.sol
  • test/src/concrete/DecimalFloat.floor.t.sol
  • test/src/concrete/DecimalFloat.format.t.sol
  • test/src/concrete/DecimalFloat.frac.t.sol
  • test/src/concrete/DecimalFloat.fromFixedDecimalLossless.t.sol
  • test/src/concrete/DecimalFloat.fromFixedDecimalLossy.t.sol
  • test/src/concrete/DecimalFloat.gt.t.sol
  • test/src/concrete/DecimalFloat.gte.t.sol
  • test/src/concrete/DecimalFloat.integer.t.sol
  • test/src/concrete/DecimalFloat.inv.t.sol
  • test/src/concrete/DecimalFloat.isZero.t.sol
  • test/src/concrete/DecimalFloat.log10.t.sol
  • test/src/concrete/DecimalFloat.lt.t.sol
  • test/src/concrete/DecimalFloat.lte.t.sol
  • test/src/concrete/DecimalFloat.max.t.sol
  • test/src/concrete/DecimalFloat.min.t.sol
  • test/src/concrete/DecimalFloat.minus.t.sol
  • test/src/concrete/DecimalFloat.mul.t.sol
  • test/src/concrete/DecimalFloat.parse.t.sol
  • test/src/concrete/DecimalFloat.pow.t.sol
  • test/src/concrete/DecimalFloat.pow10.t.sol
  • test/src/concrete/DecimalFloat.sqrt.t.sol
  • test/src/concrete/DecimalFloat.sub.t.sol
  • test/src/concrete/DecimalFloat.toFixedDecimalLossless.t.sol
  • test/src/concrete/DecimalFloat.toFixedDecimalLossy.t.sol
  • test/src/lib/deploy/LibDecimalFloatDeploy.checkLogTablesDeployed.t.sol
  • test/src/lib/table/LibLogTable.bytes.t.sol

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QyCCzi9WZPhuXcU1hwr2bq
@thedavidmeister
thedavidmeister merged commit 08057c1 into main Sep 8, 2026
9 checks passed
@thedavidmeister thedavidmeister mentioned this pull request Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant