Skip to content

Drop the library-logic tests that now run in rain.math.float - #22

Merged
thedavidmeister merged 2 commits into
2026-09-07-bindings-artifact-overridefrom
2026-09-07-bindings-tests-to-library
Sep 7, 2026
Merged

Drop the library-logic tests that now run in rain.math.float#22
thedavidmeister merged 2 commits into
2026-09-07-bindings-artifact-overridefrom
2026-09-07-bindings-tests-to-library

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

The library-logic tests this crate kept over the pinned rain-math-float package now run in rain.math.float over its own source (rainlanguage/rain.math.float#275). This crate keeps the tests of its Rust API: Default, serde, hex round-trip and error rendering.

Stacked on #21.

QA

  • Discriminating tests: cargo test 10 passed + 36 doctests; clippy clean with and without test-harness.
  • Mutations applied: none here, this is a deletion; the removed tests were mutation-probed where they now live (Run the bindings' library tests here, over this source rain.math.float#275: a broken add fails 10, a reverting constructor fails 73).
  • Oracle: the library's crates/tests suite.
  • Category check: removes only what moved; every test of the bindings' own behaviour stays.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QyCCzi9WZPhuXcU1hwr2bq

baku-ccron and others added 2 commits September 7, 2026 16:28
The crate keeps the tests of its own Rust API: Default, serde, the hex
round-trip and error rendering. The proptest seeds went with the tests.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QyCCzi9WZPhuXcU1hwr2bq
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QyCCzi9WZPhuXcU1hwr2bq
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: e563482d-a394-430a-958a-7de9504325e9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thedavidmeister
thedavidmeister merged commit d1d86a9 into 2026-09-07-bindings-artifact-override Sep 7, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant