Add Robinhood Chain (4663) to the supported network set - #161
Conversation
`LibRainDeploy.ROBINHOOD` joins `supportedNetworks()` (eighth entry, after `polygon`), so every consumer's default deploy ships its suite there too and `testZoltuFactoryCodehash` pins the factory on it. The Zoltu factory is live on 4663 with the canonical runtime (verified; the fork test passes against it). Robinhood Chain is an Arbitrum Orbit L2 settling to Ethereum, gas in ETH, EIP-1559 fees. `[rpc_endpoints]` reads `ROBINHOOD_RPC_URL`, which the rainix preflight exports once rainix#371 lands. `[etherscan]` gets an entry because `testSupportedNetworksAreFullyConfigured` requires one per network: Etherscan V2 does not index 4663, so it points at the chain's Blockscout, which speaks the Etherscan API. That explorer has rejected non-browser clients behind a browser challenge, so the entry documents the Sourcify fallback for a failed `--verify`. The key variable `CI_DEPLOY_ROBINHOOD_ETHERSCAN_API_KEY` is exported by the rainix reusables (rainix#371) so config resolution never sees it unset. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HiqQdxokJ4edjAFyAkN9G3
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe change adds Robinhood RPC and contract verification settings to Foundry. It adds Robinhood to the deployment library’s supported networks and updates the corresponding test to expect eight networks. ChangesRobinhood network support
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This adds Robinhood Chain as a supported deployment network with matching RPC, verification, and registry coverage. No concrete current-head merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds Robinhood Chain (chain id 4663, an Arbitrum Orbit L2 settling to Ethereum, gas in ETH) to
LibRainDeploy.supportedNetworks(), so every consumer's default deploy ships its suite there andtestZoltuFactoryCodehashpins the factory on it. The Zoltu factory is live on 4663 with the canonical runtime (the fork test passes against it; also verified byte-for-byte against Base on-chain).What changes
ROBINHOOD = "robinhood"constant + eighthsupportedNetworks()entry (afterpolygon);testSupportedNetworkscount/order updated.[rpc_endpoints] robinhood = "${ROBINHOOD_RPC_URL}", exported by the rainix preflight once rainlanguage/rainix#371 lands (it also carries public defaults, so no org secret is required for fork tests).[etherscan] robinhood: required bytestSupportedNetworksAreFullyConfigured. Etherscan V2 does not index 4663, so the entry points at the chain's Blockscout API (Etherscan-compatible, key ignored) withchain = 4663. rainix#371 exportsCI_DEPLOY_ROBINHOOD_ETHERSCAN_API_KEYlike the other keys so a--verifyrun never resolves it unset.Caveat, stated in the toml comment
That Blockscout has answered non-browser clients with a Cloudflare browser challenge from here, so a
--verifymay fail on this network after the broadcast. Sourcify supports 4663 and Blockscout imports Sourcify matches, so the fallback isforge verify-contract --verifier sourcify --chain 4663 …. A dispatch that only needs Robinhood can also run withverify: false.Downstream
Needs a
sol-v0.1.8release; consumers then bump and add the same two rows to their ownfoundry.toml(their inheritedRainDeployVerifySnapshottest requires both): rain.orderbook, rain.math.float (log tables), rain.tofu.erc20-decimals, rain.metadata-deploy, rainlang. Those preconditions must be on 4663 before the orderbook suite (raindexDependencies()); the deploy key0xf5b3fcb6…cce0has 0 ETH there today.Checks
testSupportedNetworks,testSupportedNetworksAreFullyConfigured,testZoltuFactoryCodehash(live forks of all eight) green;forge fmt --checkin the nix shell.Linear: RAI-2291 (parent RAI-2284).
🤖 Generated with Claude Code
https://claude.ai/code/session_01HiqQdxokJ4edjAFyAkN9G3
Summary by CodeRabbit