Skip to content

Drop foundry.toml release metadata: version intent lives in next-v tags (rainix#335) - #60

Merged
thedavidmeister merged 1 commit into
mainfrom
2026-08-19-drop-release-metadata
Aug 19, 2026
Merged

thedavidmeister merged 1 commit into
mainfrom
2026-08-19-drop-release-metadata

Conversation

@thedavidmeister

@thedavidmeister thedavidmeister commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Deletes the [external.package] release-metadata section from foundry.toml, together with the comment block attached directly above it, per the ruling in rainlanguage/rainix#335. Since rainlanguage/rainix#336 merged, rainix-autopublish derives the publish version from the Soldeer registry plus next-v* git tags and never reads this section; the publish gate also excludes the section (including its attached comment block) from the content hash, so this deletion is content-neutral and cannot mint a release.

QA

  • Discriminating tests: n/a - config-metadata deletion; nothing reads the section since rainix#336. Verified locally: nix develop -c reuse lint, nix develop -c forge soldeer install, and the full nix develop -c forge test suite all green.
  • Mutations applied: n/a - no code changed
  • Oracle: rainix#336 gate semantics (section excluded from content hash; version from registry + next-v tags)
  • Category check: issue asks removal of release metadata from consumers; covered exactly for this repo

Summary by CodeRabbit

  • Chores
    • Removed package release metadata from the project configuration.

…gs (rainix#335)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this Aug 19, 2026
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a561767a-e4ad-433d-a5bf-4d6c2d655a43

📥 Commits

Reviewing files that changed from the base of the PR and between ab7f683 and 43b57a3.

📒 Files selected for processing (1)
  • foundry.toml
💤 Files with no reviewable changes (1)
  • foundry.toml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

Removed the [external.package] release metadata block from foundry.toml. All other Foundry settings remain unchanged.

Changes

Cohort / File(s) Summary
Foundry configuration
foundry.toml
Removes the external package name and version metadata. Preserves profile, compiler, dependency, fuzz, and Soldeer settings.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 43b57

This localized configuration cleanup removes unused release metadata without changing runtime code or release behavior. No actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the removal of release metadata and the versioning mechanism referenced by the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-08-19-drop-release-metadata

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thedavidmeister
thedavidmeister merged commit c8f3188 into main Aug 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant