style: deno fmt nr.md — the denofmt hook red on main - #300
Conversation
The `denofmt` pre-commit hook reflows three paragraphs to 80 columns; the committed prose was hand-wrapped and does not match. Whitespace only. Plugin 0.21.0 -> 0.21.1: any change under plugins/ is a release the bump gate requires. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 45 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The `denofmt` pre-commit hook reflows both files to 80 columns; the prose is hand-wrapped and does not match. Whitespace only. `nr.md` is main's, red there too and fixed identically in #300; carried here because a branch inherits its base's red step. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
static / rs-staticis red onmain. The failing hook isdenofmt, and thefile it rewrites is
plugins/human-fsm/commands/nr.md.#297 was merged with this already red. The step's log carries a
Could not initialize cache database ... deleting and retryingline, whichreads like a cache flake, but that line is deno's own recovery notice and the
hook still went on to reformat the file. The real report is the two lines under
it:
files were modified by this hook, namingnr.md, followed by the diff--show-diff-on-failureprinted. The prose added by #297 was hand-wrapped anddoes not match
deno fmt's 80-column reflow.The fix
deno fmtrun from the samenix develop ...#rust-shellthe CI step uses — thehook's own tool, not a hand re-wrap. Three paragraphs in
nr.mdreflow; no wordchanges.
Plugin
0.21.0→0.21.1inplugin.jsonandmarketplace.json, because thebump gate treats any change under
plugins/as a release.Verified by re-running the exact CI step locally against this branch:
nix develop github:rainlanguage/rainix/53e96a7d...#rust-shell -c pre-commit run --all-files --show-diff-on-failure, all hooks pass.QA
two version strings, so there is no behaviour a test could discriminate. The
gate with teeth is the failing CI step itself: it is red on the base commit
and green on this branch, both runs of the same
pre-commit run --all-filesin the same pinned shell. That base-red / head-green pair is the discriminator.
re-running
deno fmtover the tree after this change reports nothing furtherto modify, which is what makes the fix complete rather than partial: a
hand-wrap that merely looks right would leave the hook still rewriting.
deno fmtas invoked by thedenofmtpre-commit hook in the pinnedrainix shell. Expected output is whatever that tool produces; nothing here is
derived from reading the file and judging its wrapping by eye.
maingo green onstatic / rs-static.Covered —
denofmtwas the only failing hook,nr.mdthe only file it named,and the full hook set passes locally on this branch. Not covered, and stated:
PR /nm and /ncc send back what they can articulate #298 fails the same hook on
nm.mdas well as inheriting thisnr.mdfailure; it is fixed on its own branch rather than here.