Skip to content

style: deno fmt nr.md — the denofmt hook red on main - #300

Merged
thedavidmeister merged 1 commit into
mainfrom
denofmt-nr-md
Aug 16, 2026
Merged

thedavidmeister merged 1 commit into
mainfrom
denofmt-nr-md

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

static / rs-static is red on main. The failing hook is denofmt, and the
file it rewrites is plugins/human-fsm/commands/nr.md.

#297 was merged with this already red. The step's log carries a
Could not initialize cache database ... deleting and retrying line, which
reads like a cache flake, but that line is deno's own recovery notice and the
hook still went on to reformat the file. The real report is the two lines under
it: files were modified by this hook, naming nr.md, followed by the diff
--show-diff-on-failure printed. The prose added by #297 was hand-wrapped and
does not match deno fmt's 80-column reflow.

The fix

deno fmt run from the same nix develop ...#rust-shell the CI step uses — the
hook's own tool, not a hand re-wrap. Three paragraphs in nr.md reflow; no word
changes.

Plugin 0.21.0 → 0.21.1 in plugin.json and marketplace.json, because the
bump gate treats any change under plugins/ as a release.

Verified by re-running the exact CI step locally against this branch:
nix develop github:rainlanguage/rainix/53e96a7d...#rust-shell -c pre-commit run --all-files --show-diff-on-failure, all hooks pass.

QA

  • Discriminating tests: n/a — the diff is whitespace in one markdown file plus
    two version strings, so there is no behaviour a test could discriminate. The
    gate with teeth is the failing CI step itself: it is red on the base commit
    and green on this branch, both runs of the same pre-commit run --all-files
    in the same pinned shell. That base-red / head-green pair is the discriminator.
  • Mutations applied: n/a — no executable lines. The equivalent check is that
    re-running deno fmt over the tree after this change reports nothing further
    to modify, which is what makes the fix complete rather than partial: a
    hand-wrap that merely looks right would leave the hook still rewriting.
  • Oracle: deno fmt as invoked by the denofmt pre-commit hook in the pinned
    rainix shell. Expected output is whatever that tool produces; nothing here is
    derived from reading the file and judging its wrapping by eye.
  • Category check: the ask is that main go green on static / rs-static.
    Covered — denofmt was the only failing hook, nr.md the only file it named,
    and the full hook set passes locally on this branch. Not covered, and stated:
    PR /nm and /ncc send back what they can articulate #298 fails the same hook on nm.md as well as inheriting this nr.md
    failure; it is fixed on its own branch rather than here.

The `denofmt` pre-commit hook reflows three paragraphs to 80 columns; the
committed prose was hand-wrapped and does not match. Whitespace only.

Plugin 0.21.0 -> 0.21.1: any change under plugins/ is a release the bump
gate requires.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@thedavidmeister, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8d91c8e9-7185-43d6-b015-4262218c0f66

📥 Commits

Reviewing files that changed from the base of the PR and between af8bb30 and a41f4ed.

📒 Files selected for processing (3)
  • .claude-plugin/marketplace.json
  • plugins/human-fsm/.claude-plugin/plugin.json
  • plugins/human-fsm/commands/nr.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

thedavidmeister pushed a commit that referenced this pull request Aug 16, 2026
The `denofmt` pre-commit hook reflows both files to 80 columns; the prose is
hand-wrapped and does not match. Whitespace only.

`nr.md` is main's, red there too and fixed identically in #300; carried here
because a branch inherits its base's red step.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@thedavidmeister
thedavidmeister merged commit 89fa2a0 into main Aug 16, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant