Replace the inset docs window with a full-viewport border layout - #32
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThe documentation UI now uses full-height bordered panes. The table of contents sits beside the article, and the header includes separate navigation, search, GitHub, and theme controls. ChangesDocumentation shell layout
Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant User
participant ThemeToggle
participant next-themes
User->>ThemeToggle: Click theme button
ThemeToggle->>next-themes: setTheme("light" or "dark")
next-themes-->>ThemeToggle: Apply selected theme
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Cloudflare preview is ready.
Production (23rd.dev) is unchanged. This preview URL stays the same as you push to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max-w-2xland centered, and restore scroll-edge blur without washing over the TOC.Dshortcut.Test plan
/docsand confirm sidebar, header, article, and TOC are edge-to-edge and separated by borders.D; confirm no hydration mismatch on the search shortcut (Ctrl vs Cmd).Made with Cursor
Summary by CodeRabbit
New Features
Style