Skip to content

fix(Menu): merge consumer props into getFloatingProps (#806)#2070

Open
kotAPI wants to merge 2 commits into
mainfrom
fix/issue-806-menu-content-getfloatingprops-batch5
Open

fix(Menu): merge consumer props into getFloatingProps (#806)#2070
kotAPI wants to merge 2 commits into
mainfrom
fix/issue-806-menu-content-getfloatingprops-batch5

Conversation

@kotAPI

@kotAPI kotAPI commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

MenuPrimitiveContent merges consumer props through getFloatingProps.\n\nFixes #806

@changeset-bot

changeset-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: bbbc2a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 513da09b-7c2e-4da5-9c94-e47e36182ff7

📥 Commits

Reviewing files that changed from the base of the PR and between 56746ce and bbbc2a3.

📒 Files selected for processing (2)
  • src/core/primitives/Menu/fragments/MenuPrimitiveContent.tsx
  • src/core/primitives/Menu/tests/MenuPrimitive.floatingProps.test.tsx
 ____________________________________________________________
< When you say, “I meant to do that,” I totally believe you. >
 ------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-806-menu-content-getfloatingprops-batch5

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Coverage

This report compares the PR with the base branch. "Δ" shows how the PR affects each metric.

Metric PR Δ
Statements 78.21% +0.01%
Branches 60.85% +0.00%
Functions 63.51% +0.00%
Lines 79.8% +0.01%

Coverage improved or stayed the same. Great job!

Run npm run coverage:ci locally for detailed reports and target untested areas to raise these numbers.

@kotAPI

kotAPI commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

Code review

Reviewed and pushed follow-up fixes addressing handler composition, test patterns (rerender vs unmount), Theme/mockMatchMedia wrappers, and flaky focus assertions.

CI was green before fixes; please re-run checks on latest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant