Skip to content

Preserve the request method and params for HTTP 308 redirects #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OskarEichler wants to merge 1 commit into from
+9 −1
Closed

Preserve the request method and params for HTTP 308 redirects #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rack/test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def follow_redirect!
raise Error, 'Last response was not a redirect. Cannot follow_redirect!'
end

if last_response.status == 307
if last_response.status == 307 || last_response.status == 308
request_method = last_request.request_method
params = last_request.params
else
Expand Down
8 changes: 8 additions & 0 deletions spec/rack/test_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,14 @@ def convert_input_hash_to_string(value)
end.must_raise(Rack::Test::Error)
end


it 'keeps the original method and params for HTTP 308' do
post '/redirect?status=308', foo: 'bar'
follow_redirect!
last_response.body.must_include 'post'
last_response.body.must_include 'foo'
last_response.body.must_include 'bar'
end
it 'keeps the original method and params for HTTP 307' do
post '/redirect?status=307', foo: 'bar'
follow_redirect!
Expand Down
Loading