Skip to content

fix(wiki): prevent Unicode memory recall from closing MCP transport - #136

Merged
rabii-chaarani merged 1 commit into
mainfrom
codex/fix-wiki-memory-transport
Sep 30, 2026
Merged

rabii-chaarani merged 1 commit into
mainfrom
codex/fix-wiki-memory-transport

Conversation

@rabii-chaarani

@rabii-chaarani rabii-chaarani commented Sep 30, 2026 •

Copy link
Copy Markdown
Owner

Unicode near a highlighted search match could put a snippet endpoint inside a UTF-8 character. During wiki_memory_recall, the resulting Rust panic exited the stdio MCP server and surfaced to clients as Transport closed.

Move excerpt endpoints outward to valid character boundaries before slicing. Add search coverage for every interior byte boundary of two-, three-, and four-byte characters on both sides of ASCII and Unicode matches, plus a real MCP process test that records and activates a Unicode memory, recalls text and structured results, and answers a subsequent ping. Record the verified diagnostic lesson in repository memory.

Validation:

  • Both new regressions failed before the fix with a UTF-8 boundary panic, including in the MCP server's main thread.
  • All 98 k-wiki tests passed.
  • cargo fmt --all --check and strict Clippy passed.
  • Repository policy gate and optimized executable MCP smoke passed.
  • Recommended wiki validation, link checks, and site build passed without diagnostics.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T21:57:46.594871Z 5bc3883 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@rabii-chaarani
rabii-chaarani merged commit 366dd54 into main Sep 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant