fix(wiki): prevent Unicode memory recall from closing MCP transport - #136
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unicode near a highlighted search match could put a snippet endpoint inside a UTF-8 character. During
wiki_memory_recall, the resulting Rust panic exited the stdio MCP server and surfaced to clients asTransport closed.Move excerpt endpoints outward to valid character boundaries before slicing. Add search coverage for every interior byte boundary of two-, three-, and four-byte characters on both sides of ASCII and Unicode matches, plus a real MCP process test that records and activates a Unicode memory, recalls text and structured results, and answers a subsequent ping. Record the verified diagnostic lesson in repository memory.
Validation:
cargo fmt --all --checkand strict Clippy passed.