Skip to content

fix(storage): keep graph reads available during Windows cleanup contention - #134

Merged
rabii-chaarani merged 4 commits into
mainfrom
codex/fix-windows-refresh-access
Sep 25, 2026
Merged

rabii-chaarani merged 4 commits into
mainfrom
codex/fix-windows-refresh-access

Conversation

@rabii-chaarani

@rabii-chaarani rabii-chaarani commented Sep 25, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Defer retired-generation deletion on Windows when an open database file denies removal, while keeping cleanup_pending visible and retrying later.
  • Restore the retirement marker after a partial delete so the next cleanup still finds the generation.
  • Add a Windows regression that holds the retired database open, verifies a newly active generation accepts search calls while cleanup is pending, then verifies collection after the handle closes.

CI failure

Run 36081364568, Windows native artifact job failed because graph_search returned Access is denied. (os error 5) during refresh recovery.

Verification

  • cargo fmt --check
  • git diff --check
  • cargo test -p codebase-graph --locked --test generation_storage (5 passed on macOS)
  • cargo test -p codebase-graph --locked --test refresh_recovery_process blocked_refresh_recovers_after_memory_budget_restore_without_source_edit (1 passed on macOS with loopback access)

The PR CI run passed all checks. Its Windows job passed both managed_reads_survive_deferred_retired_generation_deletion and the originally failing blocked_refresh_recovers_after_memory_budget_restore_without_source_edit test.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T02:17:16.823448Z 25889e3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@rabii-chaarani
rabii-chaarani merged commit fd7362f into main Sep 25, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant