fix(release): publish verified merge commits and resume blocked releases - #127
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
rabii-chaarani
had a problem deploying
to
cargo
September 24, 2026 04:29 — with
GitHub Actions
Failure
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88d824aaf3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow could permanently strand a successful release merge when another PR advanced main during CI. The pending release then blocked release-please from creating every later release proposal.
Bind publication to the release merge's own successful CI run and verify its ancestry and exact PR identity. Keep release-please proposal-only; create the selected tag/release after production and artifact validation, publish the same source to crates.io, and finalize only that PR. Add explicit
resume-ci-runrecovery, default manual dispatch to dry-run, make retries idempotent, and report pending-release blockers directly.Validation: 31 xtask tests (including execution of the actual workflow Bash against a closed mock GitHub API), formatting, Clippy with warnings denied, and workflow policy checks. Actionlint 1.7.12 passes apart from the newly documented
concurrency.queue: maxproperty, which that validator does not yet recognize. GitHub accepted the workflow in dispatch 35955798141; its exact-CI, release-PR, and immutable metadata checks passed before the expected main-only cargo environment restriction stopped the branch dry-run. Updated release documentation and curated wiki validation/link/build checks pass.The historical 2.0.0 release will be recovered separately from its original successful CI run after this workflow is available on main. No newer commit or rebuilt artifact may substitute for that run.