Skip to content

fix(release): publish verified merge commits and resume blocked releases - #127

Merged
rabii-chaarani merged 1 commit into
mainfrom
codex/fix-release-publication
Sep 24, 2026
Merged

rabii-chaarani merged 1 commit into
mainfrom
codex/fix-release-publication

Conversation

@rabii-chaarani

@rabii-chaarani rabii-chaarani commented Sep 24, 2026 •

Copy link
Copy Markdown
Owner

The release workflow could permanently strand a successful release merge when another PR advanced main during CI. The pending release then blocked release-please from creating every later release proposal.

Bind publication to the release merge's own successful CI run and verify its ancestry and exact PR identity. Keep release-please proposal-only; create the selected tag/release after production and artifact validation, publish the same source to crates.io, and finalize only that PR. Add explicit resume-ci-run recovery, default manual dispatch to dry-run, make retries idempotent, and report pending-release blockers directly.

Validation: 31 xtask tests (including execution of the actual workflow Bash against a closed mock GitHub API), formatting, Clippy with warnings denied, and workflow policy checks. Actionlint 1.7.12 passes apart from the newly documented concurrency.queue: max property, which that validator does not yet recognize. GitHub accepted the workflow in dispatch 35955798141; its exact-CI, release-PR, and immutable metadata checks passed before the expected main-only cargo environment restriction stopped the branch dry-run. Updated release documentation and curated wiki validation/link/build checks pass.

The historical 2.0.0 release will be recovered separately from its original successful CI run after this workflow is available on main. No newer commit or rebuilt artifact may substitute for that run.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T04:30:41.345540Z 88d824a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 88d824aaf3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release.yml
@rabii-chaarani
rabii-chaarani merged commit 4594f38 into main Sep 24, 2026
18 of 19 checks passed

This branch had an error being deployed

1 failed deployment
cargo — 88d824aa Deployed Sep 24, 2026 by rabii-chaarani via production release gate #124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant