Feat/verify then commit - #5
Merged
Merged
Conversation
Completes the client side of verify-then-commit (docs/VERIFY_THEN_COMMIT.md gap #1): the remote TUI can now answer interactive stdin requests instead of only noticing them. - ServerEvent::StdinRequest arms a pending-answer state and shows the prompt in the transcript (empty prompts get a status notice) - Enter sends the composer line as Request::StdinResponse - the first caller of the previously dead send_stdin_response path - so verify- then-commit approvals and interactive bash stdin both work remotely - Esc declines with an empty reply (the edit gate treats it as a rejection) while preserving the draft for reuse - other keys fall through so the user can scroll/edit while waiting - replies are excluded from cross-session prompt history - 4 wire-level tests using the dummy socketpair idiom assert the actual StdinResponse frames; in-workspace edit_approval suite now 13/13 Default remains off: local sessions have no stdin channel today, so the gate fails closed there (documented).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.