Simplify build system to avoid cmake#45
Merged
Merged
Conversation
Replace the cmake-based bundled build with direct compilation of the libfswatch sources into the package shared object via explicit per-object Makevars rules. No cmake, no static archive, no install step, and no GNU make dependency. - Hand-maintained libfswatch_config.h selects features from compiler platform macros (no install-time probing). - configure keeps only system-libfswatch detection, the -latomic probe and the macOS -framework CoreServices flag; emits @cppflags@/@libs@/@fsw_objects@. - Static Makevars.win/.ucrt; configure.win/.ucrt removed (Biarch kept). - Self-guard fsevents/inotify/fanotify monitors so one POSIX object list works across all POSIX OSes (wrong-OS monitors compile to empty objects). - Neuter libfswatch's diagnostic logging so the compiled package writes nothing to stdout/stderr (keeps R CMD check 'compiled code' clean now that libfswatch is linked into watcher.so rather than a separate, deleted lib). - All source patches live in an idempotent tools/patch_libfswatch.sh, called by tools/update_libfswatch.sh, which also regenerates the Makevars and the POSIX object list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44.
Replace the cmake-based bundled build with direct compilation of the
libfswatchsources into the package shared object via explicit per-object Makevars rules. No cmake, no static archive, no install step, and no GNU make dependency.libfswatch_config.hselects features from compiler platform macros (no install-time probing).-latomic probeand the macOS-framework CoreServicesflag; emits@cppflags@ / libs@ / @fsw_objects@.Makevars.win/.ucrt;configure.win/.ucrtremoved (Biarchkept).libfswatchis linked intowatcher.sorather than a separate, deleted lib).tools/patch_libfswatch.sh, called bytools/update_libfswatch.sh, which also regenerates the Makevars and the POSIX object list.