Repository navigation
Keep inst/doc and continue when answering No to the clean_doc prompt - #229
Merged
Merged
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Answering "No" to the interactive "Building the package will delete inst/doc, are you sure?" prompt hits a bare
return()inbuild_setup_source(). That returnsNULLtobuild(), which then fails with an unrelated error:Now "No" (or cancelling the prompt) skips the deletion and the build continues, so
inst/docis kept, matching whatclean_doc = FALSEdoes. Only "Yes" deletes it. The prompt now reads "Delete it and build ('Yes'), or keep it and build ('No')?" so it's clear what each answer does.The test mocks the prompt through a small
is_interactive()wrapper, because mocking baseinteractive()doesn't take effect once the function has been byte-compiled.Before/after on 19
build()setups (clean_docNULL/TRUE/FALSE,Config/build/clean-inst-docTRUE/FALSE/unset,vignetteson/off, noinst/doc, binary build, interactive Yes/No): the other 18 give identical tarball contents. The one that changes is interactive "No" with nothing configured, which used to error. Full test suite passes.Closes #186