Repository navigation
Conversation
PwCore::start() creates a pw_loop but never calls pw_loop_enter() before iterating it via QSocketNotifier. This triggers SPA's internal assertion impl->enter_count > 0 at loop.c:817 on every pw_loop_iterate() call, causing the PipeWire connection to fail silently. Add pw_loop_enter() after pw_loop_new() and pw_loop_leave() before pw_loop_destroy() to properly manage the loop lifecycle. Assisted-by: MiMoCode + MiMo-V2.5-Pro
Member
|
Its unclear if we should enter this when processing pipewire events (from socket notify) or just for the full duration of the connection and there is zero documentation (as usual). I also don't get this so I guess they changed an assertion in a newer package version than I'm on. Did you try both positions or know why it should go around the app event loop vs event stream handling? |
Member
|
Did some research, looks correct. Can you enable maintainer edits on the branch? |
outfoxxed
force-pushed
the
master
branch
2 times, most recently
from
October 6, 2026 04:21
72a1ce2 to
11ca60b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
PwCore::start() creates a pw_loop but never calls pw_loop_enter() before iterating it via QSocketNotifier. This triggers SPA's internal assertion impl->enter_count > 0 at loop.c:817 on every pw_loop_iterate() call, causing the PipeWire connection to fail silently.
Add pw_loop_enter() after pw_loop_new() and pw_loop_leave() before pw_loop_destroy() to properly manage the loop lifecycle.
Additional information
Before the fix: clicking the audio icon had no response, and audio volume adjustment did not work.
After the fix: audio volume adjustment works correctly.
Requirements