Skip to content

networking: prefer AP security, NM settings without wireless security are open - #1245

Merged
outfoxxed merged 1 commit into
quickshell-mirror:masterfrom
cpwrs:prefer-ap-security
Oct 5, 2026
Merged

outfoxxed merged 1 commit into
quickshell-mirror:masterfrom
cpwrs:prefer-ap-security

Conversation

@cpwrs

@cpwrs cpwrs commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Fixes the securityFromSettingsMap utility. An NMSettingsMap without the 802-11-wireless-security map is considered WifiSecurityType.Open.

Also fixes the updateSecurity lambda to prefer the security of the reference AP over the reference settings. This is correct because an active connection doesn't automatically apply changes made to the settings. Updates to 802-11-wireless-security wouldn't change the actual security being used by the active connection.

Closes #1229.

@outfoxxed
outfoxxed merged commit 8fd0e25 into quickshell-mirror:master Oct 5, 2026
36 checks passed
@outfoxxed

Copy link
Copy Markdown
Member

thanks

@cpwrs
cpwrs deleted the prefer-ap-security branch October 5, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Networking: saved open Wi-Fi profiles report Unknown security when the security settings group is absent

2 participants