[Causal-LM Test]: Adding causal lm test cases for diff configs - #1180
Open
abukhoy wants to merge 15 commits into
Open
[Causal-LM Test]: Adding causal lm test cases for diff configs#1180abukhoy wants to merge 15 commits into
abukhoy wants to merge 15 commits into
Conversation
Closed
quic-rishinr
requested review from
quic-hemagnih,
quic-rishinr and
vbaddi
and removed request for
vbaddi
July 15, 2026 05:13
quic-hemagnih
requested changes
Jul 17, 2026
|
|
||
| test_models_blocking_dict = {"openai/gpt-oss-20b": "tiny-random/gpt-oss-bf16"} | ||
| test_models_chunking_dict = {"Qwen/Qwen3-30B-A3B-Instruct-2507": "hf-internal-testing/tiny-random-Qwen3MoeForCausalLM"} | ||
|
|
Contributor
There was a problem hiding this comment.
Add gemma4-26B model also
| @pytest.mark.llm # FIXME split into llm and vllm later | ||
| @pytest.mark.parametrize("model_id", model_id_blocking) | ||
| @pytest.mark.parametrize("prompt", prompts) | ||
| def test_disagg_mode_prefill(model_id, prompt): |
Contributor
There was a problem hiding this comment.
What is this test for? I think we can check the functionality in test_disagg_mode_prefill_only_and_decode_only.
Anything specific we want to check with this test?
| @pytest.mark.parametrize("prompt", [prompt1]) | ||
| def test_disagg_mode_prefill_only_and_decode_only(model_id, prompt): | ||
| PREFILL_SEQ_LEN = 256 | ||
| CTX_LEN = 256 |
Contributor
There was a problem hiding this comment.
why prefill_seq_len and ctx_len same?
| @pytest.mark.llm # FIXME split into llm and vllm later | ||
| @pytest.mark.parametrize("model_id", model_id_blocking) | ||
| @pytest.mark.parametrize("prompt", [prompt1]) | ||
| def test_disagg_mode_prefix_caching(model_id, prompt): |
Contributor
There was a problem hiding this comment.
Lets add a note on top of each test case something like
Test case Name:
Intent of this test:
Feature impact if it fails:
This will make our life very easy in quick review down the line when number of test cases will increase
| kv_out_batch0[f"past_value.{i}_RetainedState"][0] - kv_out_batch1[f"past_value.{i}_RetainedState"][1] | ||
| ).max() | ||
| < QAIC_ATOL | ||
| ) |
Contributor
There was a problem hiding this comment.
Where is decode only tests? That is PL =1. Do we need those tests or not?
quic-rishinr
requested changes
Jul 23, 2026
quic-rishinr
left a comment
quic-rishinr
left a comment
Contributor
There was a problem hiding this comment.
Please rebase the PR
Signed-off-by: Abukhoyer SHaik <abukhoye@qti.qualcomm.com>
…tilities - Extract common logic into gpt_oss_utils: - input preparation (_prepare_inputs) - dummy model creation (_make_dummy_model) - standardized compile kwargs (_default_compile_kwargs) - HF prefill execution (_run_hf_prefill) - QEff prefill execution (_run_qeff_prefill) - QPC execution (_run_qpc_prefill) - sliding-window KV rotation (_rotate_sliding_kv) - prefix caching inference (_prefix_caching_inference) - Refactor tests to use shared helpers instead of inline logic - Remove duplicated tokenization, KV cache, and session handling code - Unify naming conventions and constants (TORCH_ATOL, QAIC_ATOL) Signed-off-by: Vishali Senthilkumar <vishsent@qti.qualcomm.com>
Signed-off-by: Abukhoyer SHaik <abukhoye@qti.qualcomm.com>
Signed-off-by: Abukhoyer SHaik <abukhoye@qti.qualcomm.com>
Signed-off-by: Abukhoyer SHaik <abukhoye@qti.qualcomm.com>
Signed-off-by: Abukhoyer SHaik <abukhoye@qti.qualcomm.com>
Signed-off-by: Abukhoyer Shaik <abukhoye@qti.qualcomm.com>
Signed-off-by: Abukhoyer Shaik <abukhoye@qti.qualcomm.com>
Signed-off-by: Abukhoyer Shaik <abukhoye@qti.qualcomm.com>
Signed-off-by: Abukhoyer SHaik <abukhoye@qti.qualcomm.com>
Signed-off-by: Abukhoyer Shaik <abukhoye@qti.qualcomm.com>
Signed-off-by: Abukhoyer Shaik <abukhoye@qti.qualcomm.com>
Signed-off-by: Abukhoyer Shaik <abukhoye@qti.qualcomm.com>
… list and params Signed-off-by: Abukhoyer Shaik <abukhoye@qti.qualcomm.com>
abukhoy
force-pushed
the
causal-test-infra
branch
from
July 23, 2026 09:57
608f6c8 to
80079d7
Compare
Signed-off-by: Abukhoyer Shaik <abukhoye@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is created for adding all the different test case for each text model with tiny models.
Test cases are following:
Each test case is separated with non-qaic part (export/compile) and qaic part (generate) so that later we can parallelize the export/compile i.e., non-qaic methods.