feat(aws/ami): Sales 계정 AMI 승격 자동화 - #146
Conversation
QPE AMI와 backing snapshot을 Sales 계정에 임시 공유하고, us-east-1 복사와 Marketplace 구조 검증을 자동화합니다. 승격 완료 후 공유 권한을 회수하며 복사 상태에 따른 롤백과 재실행 경계를 추가합니다. Co-Authored-By: Atlas <atlas@jk.agent>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f297913de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
진행 중인 Sales AMI의 권한 복구 전에 복사 상태를 표시해 실패 시 공유를 유지합니다. 복사 시작 전 실패에서는 임시 공유 권한 전체를 검증하며 회수하고, 회수 실패 시 재시도 안내를 출력합니다. Co-Authored-By: Atlas <atlas@jk.agent>
권한 조회 실패를 권한 부재와 구분하고 오류 종료 코드를 보존한다. 계정, 중복 AMI, 잘못된 인자와 정리 검증 실패 회귀 테스트를 추가한다. Co-Authored-By: Atlas <atlas@jk.agent>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cfdaa7a7ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CopyImage 응답이 불명확하면 원본 공유를 유지해 진행 중인 복사를 보호한다. terminal Sales AMI는 retry-N 시도로 자동 대체하고 재실행 절차와 회귀 테스트를 갱신한다. Co-Authored-By: Atlas <atlas@jk.agent>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d220b749ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
옵션 구분자 뒤의 위치 인자를 보존해 표준 -- 사용 방식에서도 AMI ID가 정상 처리되도록 한다. 해당 호출 경로를 Bats 회귀 테스트로 검증한다. Co-Authored-By: Atlas <atlas@jk.agent>
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Why
What
ami-promote-to-sales.sh <qpe-ami-id>명령을 추가합니다.us-east-1에 비암호화 AMI를 복사하고 Marketplace 구조 검증을 실행합니다.retry-N시도로 자동 대체합니다.aws/ami/README.md에 실행 전제조건과 승격·회수 흐름을 문서화합니다.Impact
qpe,salesprofile은 저장소 밖에서 사전에 설정하고 로그인해야 합니다.Added/updated tests?
bash -n aws/ami/ami-promote-to-sales.shbats aws/ami/tests/*.bats— 40 tests passedAdditional notes